Author: ericwf
Date: Thu Oct 1 02:05:38 2015
New Revision: 248987
URL: http://llvm.org/viewvc/llvm-project?rev=248987&view=rev
Log:
Suppress array initialization warnings in std::experimental::apply tests
Added:
libcxx/trunk/test/support/disable_missing_braces_warning.h
Removed:
libcxx/t
Author: ericwf
Date: Thu Oct 1 02:29:38 2015
New Revision: 248988
URL: http://llvm.org/viewvc/llvm-project?rev=248988&view=rev
Log:
Fix initialzation order in dynarray
Modified:
libcxx/trunk/include/experimental/dynarray
Modified: libcxx/trunk/include/experimental/dynarray
URL:
http://llvm
xazax.hun added a subscriber: xazax.hun.
xazax.hun added a comment.
If you check AvoidCStyleCastsCheck.cpp, it also suggest what kind of cast
should you use to replace a C style cast. Probably, in some cases, the
developers might be able to change the reinterpret_cast to something more type
saf
EricWF created this revision.
EricWF added reviewers: mclow.lists, danalbert, jroelofs.
EricWF added a subscriber: cfe-commits.
Currently the test suite defaults to C++11 mode if no standard version is
supplied to LIT using `--param=std=c++XX`. This patch changes that behavior so
that the newes
Author: ericwf
Date: Thu Oct 1 02:41:07 2015
New Revision: 248989
URL: http://llvm.org/viewvc/llvm-project?rev=248989&view=rev
Log:
Manually suppress -Wnonnull when it occurs in an unevaluated context
Modified:
libcxx/trunk/test/std/depr/depr.c.headers/stdlib_h.pass.cpp
libcxx/trunk/test
seaneveson added a comment.
Could you update this patch to the latest trunk please? There's a conflict with
http://reviews.llvm.org/rL248516.
Thanks.
http://reviews.llvm.org/D12993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
Comment at: include/clang/Tooling/Tooling.h:437
@@ +436,3 @@
+///
+/// \note This will not set \c CommandLine[0] to \c InvokedAs.
+void addTargetAndModeForProgramName(std::
EricWF created this revision.
EricWF added a reviewer: mclow.lists.
EricWF added subscribers: cfe-commits, mclow.lists.
constructing a std::unique_ptr will always cause a warning because the
deleter (`std::default_delete`) will call `delete ptr` instead of `delete
[] ptr`. This is a bug in the s
klimek added a comment.
In http://reviews.llvm.org/D13318#257091, @echristo wrote:
> This seems a little odd, could you explain in a bit more detail? Me not
> understanding I imagine. :)
Seems to be explained well in the comments?
If the compilation database contains:
i686-linux-android-g++
Author: ericwf
Date: Thu Oct 1 03:34:37 2015
New Revision: 248993
URL: http://llvm.org/viewvc/llvm-project?rev=248993&view=rev
Log:
Attempt to prevent flaky thread.mutex tests by once again increasing timing
tolerances
Modified:
libcxx/trunk/test/std/thread/thread.mutex/thread.lock/thread.
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
... Which indicates that the tests might need better names and more comments,
so I don't mess them up next time :D
http://reviews.llvm.org/D13292
__
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D13249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
On 1 October 2015 at 05:19, Piotr Padlewski via cfe-commits
wrote:
> Author: prazek
> Date: Wed Sep 30 23:19:45 2015
> New Revision: 248984
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248984&view=rev
> Log:
> Test fix
Almost there... :)
http://lab.llvm.org:8011/builders/clang-cmake-armv7-a1
EricWF abandoned this revision.
EricWF added a comment.
This change is garbage. Sorry for the noise.
http://reviews.llvm.org/D13062
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
@mclow.lists ping. I would like to keep moving on the LFTS v1 work.
http://reviews.llvm.org/D11397
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
angelgarcia updated this revision to Diff 36198.
angelgarcia added a comment.
Yes, right now it is pretty hard to figure out what some of the tests are for,
they are a bit messy. I plan to do something about it, but for now I added a
comment on that test.
http://reviews.llvm.org/D13292
Files:
Author: angelgarcia
Date: Thu Oct 1 03:57:11 2015
New Revision: 248994
URL: http://llvm.org/viewvc/llvm-project?rev=248994&view=rev
Log:
Add support for 'cbegin()' and 'cend()' on modernize-loop-convert.
Summary:
This fixes https://llvm.org/bugs/show_bug.cgi?id=22196 .
Also add a non-trivially
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248994: Add support for 'cbegin()' and 'cend()' on
modernize-loop-convert. (authored by angelgarcia).
Changed prior to commit:
http://reviews.llvm.org/D13292?vs=36198&id=36200#toc
Repository:
rL LLVM
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
The patch looks good with one comment. I'll fix it and submit the patch for you.
Thank you for working on this!
Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:5
alexfh added inline comments.
Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:548
@@ +547,3 @@
+ }
+
+ if (const auto *Loc = Result.Nodes.getNodeAs("typeLoc")) {
alexfh wrote:
> Note, that I suggested to use `Loc->getType()->getDecl()`, which uses
Author: alexfh
Date: Thu Oct 1 04:19:40 2015
New Revision: 248996
URL: http://llvm.org/viewvc/llvm-project?rev=248996&view=rev
Log:
[clang-tidy] Implement FixitHints for identifier references in
IdentifierNamingCheck
This diff requires http://reviews.llvm.org/D13079 to be applied first. I wasn'
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248996: [clang-tidy] Implement FixitHints for identifier
references in… (authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D13081?vs=35974&id=36202#toc
Repository:
rL LLVM
http:/
Author: alexfh
Date: Thu Oct 1 04:23:20 2015
New Revision: 248997
URL: http://llvm.org/viewvc/llvm-project?rev=248997&view=rev
Log:
[clang-tidy] fix add_new_check.py
Before this check, I would get the following error:
Updating ./misc/CMakeLists.txt...
Creating ./misc/NoReinterpret_castCheck.h..
alexfh added a comment.
In http://reviews.llvm.org/D13272#256305, @mgehre wrote:
> Yes, please. Btw, I'm going to submit some diffs for clang-tidy checks (for
> the CppCoreGuidelines). Which reviewers should I set on them?
Please always add me to the reviewers and cfe-commits to Subscribers. A
alexfh added a comment.
Also note, that in October I'll be mostly unavailable, but other clang-tidy
contributors can do the review and help getting patches in: sbenza, bkramer,
aaron.ballman.
Repository:
rL LLVM
http://reviews.llvm.org/D13081
_
berenm added a comment.
Alright, thank you for your time!
Repository:
rL LLVM
http://reviews.llvm.org/D13081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
berenm updated this revision to Diff 36207.
berenm added a comment.
Fix arcanist insisting on creating the diff against old revision...
http://reviews.llvm.org/D12362
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/WhitespaceManager.cpp
lib/Format/WhitespaceManager
berenm marked 7 inline comments as done.
Comment at: unittests/Format/FormatTest.cpp:8699
@@ +8698,3 @@
+ "int one = 1;\n"
+ "\n"
+ "unsigned oneTwoThree = 123;",
I think I actually managed to do something
berenm marked 2 inline comments as done.
berenm added a comment.
http://reviews.llvm.org/D12362
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
The patch doesn't apply cleanly. Please update it.
http://reviews.llvm.org/D12839
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
This looks awesome. Do you have commit access?
Comment at: unittests/Format/FormatTest.cpp:8699
@@ +8698,3 @@
+ "int one = 1;\n"
+ "
berenm added a comment.
Thanks, I don't have commit access.
http://reviews.llvm.org/D12362
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper closed this revision.
djasper added a comment.
Submitted as r248999. Thank you!
http://reviews.llvm.org/D12362
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: djasper
Date: Thu Oct 1 05:06:54 2015
New Revision: 248999
URL: http://llvm.org/viewvc/llvm-project?rev=248999&view=rev
Log:
[clang-format] Add support of consecutive declarations alignment
This allows clang-format to align identifiers in consecutive
declarations. This is useful for incr
ABataev created this revision.
ABataev added a reviewer: rnk.
ABataev added a subscriber: cfe-commits.
MSVC supports 'property' attribute and allows to apply it to the declaration of
an empty array in a class or structure definition.
For example:
```
__declspec(property(get=GetX, put=PutX)) int x
EricWF created this revision.
EricWF added a reviewer: mclow.lists.
EricWF added a subscriber: cfe-commits.
Hi Marshall,
Could you please test this patch and see if you run into the same linker errors
we talked about?
I can't reproduce on linux or OS X.
Hopefully you can't find any problems and
Author: yrnkrn
Date: Thu Oct 1 06:19:28 2015
New Revision: 249001
URL: http://llvm.org/viewvc/llvm-project?rev=249001&view=rev
Log:
C++11 rangify for loops, NFC.
Modified:
cfe/trunk/lib/Frontend/InitHeaderSearch.cpp
Modified: cfe/trunk/lib/Frontend/InitHeaderSearch.cpp
URL:
http://llvm.or
vkalintiris created this revision.
vkalintiris added reviewers: atanasyan, rsmith.
vkalintiris added a subscriber: cfe-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
This patch moves getCompilerRT() from the clang::driver::tools namespace to
the ToolChain class. This is needed
vkalintiris created this revision.
vkalintiris added reviewers: atanasyan, dsanders, rsmith.
vkalintiris added a subscriber: cfe-commits.
Herald added subscribers: dschuff, srhines, danalbert, tberghammer, jfb.
This new toolchain uses primarily LLVM-based tools, eg. compiler-rt, lld,
libcxx, etc.
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added reviewers: aaron.ballman, alexfh.
aaron.ballman added a comment.
As a slightly more broad question: I think we should have a user-customizable
way to categorize these checks so that you can enable/disable them with
finer-graine
angelgarcia created this revision.
angelgarcia added a reviewer: klimek.
angelgarcia added subscribers: alexfh, cfe-commits.
This fixes https://llvm.org/bugs/show_bug.cgi?id=17716.
http://reviews.llvm.org/D13342
Files:
clang-tidy/modernize/LoopConvertCheck.cpp
clang-tidy/modernize/LoopConver
klimek added inline comments.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:455-457
@@ +454,5 @@
+///
+/// FIXME: if 'next_instruction' is a closing brace ('}'), after the
replacement
+/// it will be over-indented. But then, who would declare an alias and do
+/// nothing
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
apart from that LG
http://reviews.llvm.org/D13342
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
angelgarcia updated this revision to Diff 36234.
angelgarcia added a comment.
Change a comment.
http://reviews.llvm.org/D13342
Files:
clang-tidy/modernize/LoopConvertCheck.cpp
clang-tidy/modernize/LoopConvertCheck.h
test/clang-tidy/modernize-loop-convert-extra.cpp
Index: test/clang-tidy/
alexfh added a comment.
In http://reviews.llvm.org/D13313#257476, @aaron.ballman wrote:
> As a slightly more broad question: I think we should have a user-customizable
> way to categorize these checks so that you can enable/disable them with
> finer-grained control. Some of the existing checker
Author: rengolin
Date: Thu Oct 1 07:58:41 2015
New Revision: 249005
URL: http://llvm.org/viewvc/llvm-project?rev=249005&view=rev
Log:
Revert "Decorating virtual functions load with invariant.load" and fix
This reverts commit r248982 as it was breaking the ARM buildbots and the fix
didn't work.
alexfh added a comment.
In http://reviews.llvm.org/D13313#256982, @vsk wrote:
> The patch lgtm. Has there been a discussion on cfe-dev about adopting these
> guidelines?
>
> I count well over 500 uses of reinterpret_cast in llvm+clang, so we might not
> all be on the same page on this.
I don'
Right, I reverted both commits on r249005. Please, let me know if you
need help testing on ARM before the next commit. This looks like it
could be tested on any 32-bit platform, though, so you should be able
to get it passing on ARM if you test and make it pass on x86.
On 1 October 2015 at 09:44,
Author: angelgarcia
Date: Thu Oct 1 08:08:21 2015
New Revision: 249006
URL: http://llvm.org/viewvc/llvm-project?rev=249006&view=rev
Log:
Prevent loop-convert from leaving empty lines after removing an alias
declaration.
Summary: This fixes https://llvm.org/bugs/show_bug.cgi?id=17716.
Reviewers
alexfh added a comment.
A high-level comment: the "misc" module is the place for checks that we didn't
find (or create) a better category for. Here it's clear that we need a separate
category, so we need a `CppCoreGuidelinesModule` and the `cppcoreguidelines-`
check prefix. I also suggest using
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM with a nit.
Comment at: include/clang/Driver/ToolChain.h:253
@@ -252,1 +252,3 @@
+ virtual SmallString<128> getCompilerRT(const llvm::opt::ArgList &Args,
+
atanasyan added inline comments.
Comment at: include/clang/Driver/ToolChain.h:92
@@ -91,2 +91,3 @@
MultilibSet Multilibs;
+ Multilib SelectedMultilib;
This field is used by the `MipsToolChain` class only. If so, move it to that
class.
Comm
ogoffart created this revision.
ogoffart added a reviewer: cfe-commits.
This is quite useful for IDE's or other tools which would like to recover as
much as possible even if there are a few errors in the code, and discarding
the full 'if' bodies is unfortunate.
http://reviews.llvm.org/D13344
F
Author: hfinkel
Date: Thu Oct 1 08:39:49 2015
New Revision: 249009
URL: http://llvm.org/viewvc/llvm-project?rev=249009&view=rev
Log:
[PowerPC] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_* macros on all PPC cores
We support all __sync_val_compare_and_swap_* builtins (only 64-bit on 64-bit
targets) o
klimek added a subscriber: klimek.
klimek added a comment.
Not sure whether it makes sense to work around compiler bugs in CL. I assume
this happens with clang from trunk? Is there a bug filed against CL?
http://reviews.llvm.org/D13203
___
cfe-comm
angelgarcia created this revision.
angelgarcia added a reviewer: klimek.
angelgarcia added subscribers: alexfh, cfe-commits.
Improve modernize-use-auto documentation
(https://llvm.org/bugs/show_bug.cgi?id=24962).
Add documentation for modernize-make-unique.
http://reviews.llvm.org/D13346
Files:
milianw added a comment.
Is there still an error reported for the invalid condition?
Anyhow, from my POV this is excellent and should fix a bunch of issues I've
seen when using clang-c in KDevelop. I never got around to investigating it,
but it always was related to conditionals. I'm pretty sur
mcrosier added a comment.
FWIW, a llvm based solution was discussed in http://reviews.llvm.org/D12979,
but the clang solution is obviously more robust and easier to implement.
Comment at: lib/CodeGen/CodeGenFunction.h:287
@@ +286,3 @@
+ // True if the current insertion point i
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D13346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Author: angelgarcia
Date: Thu Oct 1 09:50:40 2015
New Revision: 249017
URL: http://llvm.org/viewvc/llvm-project?rev=249017&view=rev
Log:
Update clang-tidy documentation.
Summary:
Improve modernize-use-auto documentation
(https://llvm.org/bugs/show_bug.cgi?id=24962).
Add documentation for modern
yaron.keren added a subscriber: yaron.keren.
yaron.keren added a comment.
clang can't generate Visual C++ debug info except line numbers yet, so building
with VC is essential to development on Windows. While most people and our bots
are still using VC 2013 going forward supporting VC 2015 (even
klimek added a reviewer: rsmith.
klimek added a comment.
+Richard, whom we need to validate AST changes to make sure they're benign.
http://reviews.llvm.org/D13344
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: d0k
Date: Thu Oct 1 10:02:15 2015
New Revision: 249019
URL: http://llvm.org/viewvc/llvm-project?rev=249019&view=rev
Log:
[VFS] Remove unused setters. NFC.
Modified:
cfe/trunk/include/clang/Basic/VirtualFileSystem.h
Modified: cfe/trunk/include/clang/Basic/VirtualFileSystem.h
URL:
ht
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added reviewers: rsmith, aaron.ballman.
Comment at: include/clang/Basic/Attr.td:1462
@@ +1461,3 @@
+def UniqueInstantiation : InheritableAttr {
+ let Spellings = [GCC<"unique_instantiation">];
+ let Subjects = Subjec
aaron.ballman added a comment.
In http://reviews.llvm.org/D13313#257506, @alexfh wrote:
> In http://reviews.llvm.org/D13313#257476, @aaron.ballman wrote:
>
> > As a slightly more broad question: I think we should have a
> > user-customizable way to categorize these checks so that you can
> > en
echristo added a comment.
BTW as Manuel is happy it's fine with me. Still curious though.
http://reviews.llvm.org/D13318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added a comment.
I think fundamentally we are doing too much declspec property lowering in Sema.
We might want to back up and figure out how to do it in IRGen. Right now we
have bugs like this, which are probably more important than new functionality:
https://llvm.org/bugs/show_bug.cgi?id=24
neil.hickey created this revision.
neil.hickey added a reviewer: cfe-commits.
Changing behaviour of casting a true boolean to an integer vector for OpenCL.
The spec (6.2.2) states that if the boolean is true, every bit in the result
vector should be set. This change will treat the i1 value as si
s.egerton updated this revision to Diff 36252.
s.egerton added a comment.
Responded to comments made on the mailing list.
http://reviews.llvm.org/D13100
Files:
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cpp
===
--- lib/Driver/
vkalintiris updated this revision to Diff 36257.
vkalintiris marked 8 inline comments as done.
vkalintiris added a comment.
Thanks. The review comments are addressed in this update.
http://reviews.llvm.org/D13340
Files:
lib/Driver/Driver.cpp
lib/Driver/ToolChain.cpp
lib/Driver/ToolChains.
vkalintiris added inline comments.
Comment at: include/clang/Driver/ToolChain.h:147
@@ -145,1 +146,3 @@
+ const Multilib &getSelectedMultilib() const { return SelectedMultilib; }
+
atanasyan wrote:
> Do you need public access to this member function?
I discarde
majnemer added a subscriber: majnemer.
majnemer added a comment.
In http://reviews.llvm.org/D13203#257539, @klimek wrote:
> Not sure whether it makes sense to work around compiler bugs in CL. I assume
> this happens with clang from trunk? Is there a bug filed against CL?
We do this with some r
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM with a test added, see test/CodeGenCXX/override-layout.cpp for an example
of how to test external record layout.
http://reviews.llvm.org/D13276
___
spetrovic created this revision.
spetrovic added a reviewer: hfinkel.
spetrovic added a subscriber: cfe-commits.
This patch enables soft float support for ppc32 architecture and fixes the ABI
for variadic functions. This is first in set of patches for soft float support
in LLVM.
http://reviews
aaron.ballman created this revision.
aaron.ballman added reviewers: alexfh, sbenza.
aaron.ballman added a subscriber: cfe-commits.
CERT produces a set of secure coding rules and recommendations for both C
(https://www.securecoding.cert.org/confluence/display/c/SEI+CERT+C+Coding+Standard)
and C++
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249030: Allow a ToolChain to compute the path of a
compiler-rt's component. (authored by vkalintiris).
Changed prior to commit:
http://reviews.llvm.org/D13339?vs=36225&id=36265#toc
Repository:
rL LLV
Author: vkalintiris
Date: Thu Oct 1 11:54:58 2015
New Revision: 249030
URL: http://llvm.org/viewvc/llvm-project?rev=249030&view=rev
Log:
Allow a ToolChain to compute the path of a compiler-rt's component.
Summary:
This patch moves getCompilerRT() from the clang::driver::tools namespace to
the To
zarko updated this revision to Diff 36266.
zarko added a comment.
Address comment comments.
http://reviews.llvm.org/D13318
Files:
include/clang/Tooling/Tooling.h
lib/Tooling/Tooling.cpp
unittests/Tooling/ToolingTest.cpp
Index: unittests/Tooling/ToolingTest.cpp
===
Author: adrian
Date: Thu Oct 1 11:57:02 2015
New Revision: 249031
URL: http://llvm.org/viewvc/llvm-project?rev=249031&view=rev
Log:
Module debugging: Also emit Objective-C interfaces forward declarations
in their module scope when building a clang module.
Modified:
cfe/trunk/lib/CodeGen/CGDe
On Wed, Sep 30, 2015 at 2:33 PM, Duncan P. N. Exon Smith
wrote:
> +echristo, +espindola, +pcc
>
>> On 2015-Sep-30, at 12:39, Teresa Johnson wrote:
>>
>> On Wed, Sep 30, 2015 at 11:11 AM, Duncan P. N. Exon Smith
>> wrote:
>>>
On 2015-Sep-30, at 10:40, Teresa Johnson wrote:
On Wed,
zarko marked an inline comment as done.
zarko added a comment.
Thanks; would someone with commit access land this?
echristo: for a more concrete example, imagine a source code indexer that
collects up dependencies. This is a Clang tool that gets called by the build
system for each translation u
loladiro added a comment.
Thanks for the quick review.
Comment at: include/clang/Basic/Attr.td:1462
@@ +1461,3 @@
+def UniqueInstantiation : InheritableAttr {
+ let Spellings = [GCC<"unique_instantiation">];
+ let Subjects = SubjectList<[CXXRecord]>;
aaron.bal
tejohnson updated this revision to Diff 36267.
tejohnson added a comment.
Address review comments.
Instead of -fthinlto use -flto=thin, and add in -flto=full as an alias to the
existing -flto. Add tests to check for proper overriding of -flto variants on
the command line, and convert grep tests
On Thu, Oct 1, 2015 at 1:09 PM, Keno Fischer
wrote:
> loladiro added a comment.
>
> Thanks for the quick review.
>
>
>
> Comment at: include/clang/Basic/Attr.td:1462
> @@ +1461,3 @@
> +def UniqueInstantiation : InheritableAttr {
> + let Spellings = [GCC<"unique_instantiation">];
grimar updated this revision to Diff 36271.
grimar added a comment.
Added comment per review request.
http://reviews.llvm.org/D13203
Files:
ASTContext.cpp
Index: ASTContext.cpp
===
--- ASTContext.cpp
+++ ASTContext.cpp
@@ -364,1
nwilson created this revision.
nwilson added reviewers: rsmith, hubert.reinterpretcast, aaron.ballman,
faisalv, fraggamuffin.
nwilson added a subscriber: cfe-commits.
http://reviews.llvm.org/D13357
Files:
include/clang/AST/Decl.h
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl
I added !invariant.load to virtual functions load, so when optimizer see
case like this
%vtable = load ...
%1 = load (...) %vtable, !invariant.load !0
call %1(...)
%2 = load (...) %vtable, !invariant.load !0
call %2(...)
can merge the 2 virtual functions load into one like this:
%vtable = load
Author: cbieneman
Date: Thu Oct 1 13:16:56 2015
New Revision: 249048
URL: http://llvm.org/viewvc/llvm-project?rev=249048&view=rev
Log:
[CMake] Don't include the test directories if CLANG_INCLUDE_TESTS is Off
This matches Clang's behavior.
Modified:
clang-tools-extra/trunk/CMakeLists.txt
Mo
sfantao updated this revision to Diff 36263.
sfantao added a comment.
This diff refactors the original patch and is rebased on top of the latests
offloading changes inserted for CUDA.
Here I don't touch the CUDA support. I tried, however, to have the
implementation modular enough so that it cou
Author: gbiv
Date: Thu Oct 1 13:47:52 2015
New Revision: 249053
URL: http://llvm.org/viewvc/llvm-project?rev=249053&view=rev
Log:
Teach -Wtautological-overlap-compare about enums
Prior to this patch, -Wtautological-overlap-compare would only warn us
if there was a sketchy logical comparison betw
george.burgess.iv closed this revision.
george.burgess.iv marked 4 inline comments as done.
george.burgess.iv added a comment.
Changed code to address all feedback + committed as r249053. Thanks for the
reviews!
Comment at: lib/Analysis/CFG.cpp:49
@@ +48,3 @@
+tryNormalizeBinar
On Thu, Oct 1, 2015 at 2:50 PM, George Burgess IV
wrote:
> george.burgess.iv closed this revision.
> george.burgess.iv marked 4 inline comments as done.
> george.burgess.iv added a comment.
>
> Changed code to address all feedback + committed as r249053. Thanks for the
> reviews!
>
>
> ==
rtrieu added a comment.
Next time, add
> Differential Revision:
to your commit and Phabricator will close the diff automatically.
http://llvm.org/docs/Phabricator.html
Comment at: lib/Analysis/CFG.cpp:99-104
@@ +98,8 @@
+ // Currently we're only given EnumConstantDecls or
On Thu, Oct 1, 2015 at 3:01 PM, Richard Trieu wrote:
> rtrieu added a comment.
>
> Next time, add
>
>> Differential Revision:
>
>
> to your commit and Phabricator will close the diff automatically.
>
> http://llvm.org/docs/Phabricator.html
>
>
>
> Comment at: lib/Analysis/CFG.cpp
Author: dgregor
Date: Thu Oct 1 14:52:44 2015
New Revision: 249060
URL: http://llvm.org/viewvc/llvm-project?rev=249060&view=rev
Log:
Simplify Sema::DeduceFunctionTypeFromReturnExpr and eliminae a redundant check.
NFC
Modified:
cfe/trunk/lib/Sema/SemaStmt.cpp
Modified: cfe/trunk/lib/Sema/Se
> Next time, add Differential Revision: to your commit and
Phabricator will close the diff automatically.
Ooh, shiny. Thanks for letting me know!
> Doubling the expense for assert builds so that we get a slightly better
stack trace in the event our assumptions are wrong doesn't seem like a good
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249063: [analyzer] Add TK_EntireMemSpace invalidation trait.
(authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D12993?vs=35170&id=36288#toc
Repository:
rL LLVM
http://reviews
Author: dcoughlin
Date: Thu Oct 1 15:09:11 2015
New Revision: 249063
URL: http://llvm.org/viewvc/llvm-project?rev=249063&view=rev
Log:
[analyzer] Add TK_EntireMemSpace invalidation trait.
This commit supports Sean Eveson's work on loop widening. It is NFC for now.
It adds a new TK_EntireMemSpace
Author: dgregor
Date: Thu Oct 1 15:20:47 2015
New Revision: 249065
URL: http://llvm.org/viewvc/llvm-project?rev=249065&view=rev
Log:
Perform Objective-C lifetime adjustments before comparing deduced lambda result
types.
Objective-C ARC lifetime qualifiers are dropped when canonicalizing
functio
mgehre updated this revision to Diff 36291.
mgehre added a comment.
Renamed the check to cppcoreguidelines-pro-type-reinterpret-cast
http://reviews.llvm.org/D13313
Files:
clang-tidy/CMakeLists.txt
clang-tidy/Makefile
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelin
1 - 100 of 137 matches
Mail list logo
