diltsman added a comment.
Yes, please land it.
http://reviews.llvm.org/D10365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added a comment.
Unfortunately I can't get the patch to apply cleanly due to different line
endings.
http://reviews.llvm.org/D10365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
klimek added a comment.
Solved the line ending problem.
http://reviews.llvm.org/D10365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> On Aug 10, 2015, at 12:40 PM, Hans Wennborg wrote:
> On Fri, Aug 7, 2015 at 11:57 AM, Simon Pilgrim wrote:
>> On 06/08/2015 18:05, Hans Wennborg wrote:
>>>
>>> On Sun, Aug 2, 2015 at 8:28 AM, Simon Pilgrim
>>> wrote:
Author: rksimon
Date: Sun Aug 2 10:28:10 2015
New Revi
Author: klimek
Date: Fri Aug 14 04:55:36 2015
New Revision: 245036
URL: http://llvm.org/viewvc/llvm-project?rev=245036&view=rev
Log:
Add structed way to express command line options in the compilation database.
Currently, arguments are passed via the string attribute 'command',
assuming a shell-e
klimek closed this revision.
klimek added a comment.
Submitted as r245036. Thanks!
http://reviews.llvm.org/D10365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
A high level question: why is this check specific to base class initialization?
Isn't the same issue possible when initializing members, for example? What
would change if in your example `D` would have a member of type `B` instead of
deriving from it?
> One thing I am n
alexfh added a comment.
In http://reviews.llvm.org/D11784#224386, @alexfh wrote:
> Converting the script to python seems like the most universal approach.
> Should be trivial with the `sh` python package, but I'm not sure whether we
> can rely on it being installed.
Actually, python sh doesn'
angelgarcia updated this revision to Diff 32143.
angelgarcia added a comment.
Update tests.
http://reviews.llvm.org/D12017
Files:
clang-tidy/IncludeInserter.cpp
clang-tidy/IncludeSorter.cpp
clang-tidy/IncludeSorter.h
unittests/clang-tidy/IncludeInserterTest.cpp
Index: unittests/clang-t
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Thanks for fixing this! Looks good with a comment.
Comment at: clang-tidy/IncludeSorter.cpp:118
@@ +117,3 @@
+ if (SourceLocations.empty()) {
+// If there are no includes
klimek added inline comments.
Comment at: clang-tidy/IncludeSorter.cpp:144
@@ -138,3 +143,3 @@
IncludeKinds NonEmptyKind = IK_InvalidInclude;
- for (int i = IncludeKind - 1; i >= 0; --i) {
+ for (int i = IK_InvalidInclude - 1; i >= 0; --i) {
if (!IncludeBucket[i].empty()
angelgarcia updated this revision to Diff 32146.
angelgarcia added a comment.
Add comments.
http://reviews.llvm.org/D12017
Files:
clang-tidy/IncludeInserter.cpp
clang-tidy/IncludeSorter.cpp
clang-tidy/IncludeSorter.h
unittests/clang-tidy/IncludeInserterTest.cpp
Index: unittests/clang-t
Author: klimek
Date: Fri Aug 14 06:47:51 2015
New Revision: 245040
URL: http://llvm.org/viewvc/llvm-project?rev=245040&view=rev
Log:
Fix AST matcher documentation.
Fix a bug in the matcher docs where callExpr(on(...)) was in the examples,
but didn't work (on() only works for memberCallExpr).
Fix
aaron.ballman added a comment.
In http://reviews.llvm.org/D11784#224386, @alexfh wrote:
> A high level question: why is this check specific to base class
> initialization? Isn't the same issue possible when initializing members, for
> example? What would change if in your example `D` would have
aaron.ballman added a comment.
In http://reviews.llvm.org/D11784#220654, @aaron.ballman wrote:
> Ping?
>
> FWIW, this patch almost caught a bug in LLVM. ;-) DependenceAnalysis.h has a
> class: FullDependence which would suffer from this problem if the Dependence
> base class did not accidentall
alexfh added a comment.
In http://reviews.llvm.org/D11784#224421, @aaron.ballman wrote:
> In http://reviews.llvm.org/D11784#224386, @alexfh wrote:
>
> > > One thing I am not certain of in this patch is how to test it. I have
> > > some rudimentary tests, but am unable to test the "note:" diagnos
alexfh added a comment.
In http://reviews.llvm.org/D11784#224424, @aaron.ballman wrote:
> In http://reviews.llvm.org/D11784#220654, @aaron.ballman wrote:
>
> >
>
>
> Do you think that this patch should have an option for the case where the
> initialization cannot use a move constructor because t
aaron.ballman added a comment.
In http://reviews.llvm.org/D11784#224430, @alexfh wrote:
> In http://reviews.llvm.org/D11784#224421, @aaron.ballman wrote:
>
> > In http://reviews.llvm.org/D11784#224386, @alexfh wrote:
> >
> > > > One thing I am not certain of in this patch is how to test it. I hav
Author: abataev
Date: Fri Aug 14 07:25:37 2015
New Revision: 245041
URL: http://llvm.org/viewvc/llvm-project?rev=245041&view=rev
Log:
[OPENMP] Fix for http://llvm.org/PR24371: Assert failure compiling blender 2.75.
blender uses statements expression in condition of the loop under control of
the '
Author: alexfh
Date: Fri Aug 14 07:33:25 2015
New Revision: 245042
URL: http://llvm.org/viewvc/llvm-project?rev=245042&view=rev
Log:
[clang-tidy] Fix IncludeInserter/IncludeSorter bug.
If there weren't any includes in the file, or all of them had 'IncludeKind'
greater than the desired one, then '
alexfh closed this revision.
alexfh added a comment.
Committed revision 245042.
http://reviews.llvm.org/D12017
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
In http://reviews.llvm.org/D11784#224433, @aaron.ballman wrote:
> In http://reviews.llvm.org/D11784#224430, @alexfh wrote:
>
> > In http://reviews.llvm.org/D11784#224421, @aaron.ballman wrote:
> >
> > > In http://reviews.llvm.org/D11784#224386, @alexfh wrote:
> > >
> > > >
aaron.ballman added a comment.
In http://reviews.llvm.org/D11784#224437, @alexfh wrote:
> In http://reviews.llvm.org/D11784#224433, @aaron.ballman wrote:
>
> > In http://reviews.llvm.org/D11784#224430, @alexfh wrote:
> >
> > > In http://reviews.llvm.org/D11784#224421, @aaron.ballman wrote:
> > >
Author: djasper
Date: Fri Aug 14 07:44:06 2015
New Revision: 245043
URL: http://llvm.org/viewvc/llvm-project?rev=245043&view=rev
Log:
clang-format: Don't remove space between #elif and parentheses.
Before:
#elif( && )
After:
#elif ( && )
Modified:
cfe/trunk/lib/Format/Fo
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Now the tests pass. Thanks for fixing the IncludeInserter bug!
http://reviews.llvm.org/D11946
___
cfe-commits mailing list
cfe-commits@lists.llvm
Author: alexfh
Date: Fri Aug 14 08:17:11 2015
New Revision: 245045
URL: http://llvm.org/viewvc/llvm-project?rev=245045&view=rev
Log:
[clang-tidy] Create clang-tidy module modernize. Add pass-by-value check.
This is the first step for migrating cppmodernize to clang-tidy.
http://reviews.llvm.org/
alexfh closed this revision.
alexfh added a comment.
Committed revision 245045.
http://reviews.llvm.org/D11946
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: alexfh
Date: Fri Aug 14 08:23:55 2015
New Revision: 245046
URL: http://llvm.org/viewvc/llvm-project?rev=245046&view=rev
Log:
[clang-tidy] Don't use delegating constructors.
Modified:
clang-tools-extra/trunk/unittests/clang-tidy/IncludeInserterTest.cpp
Modified: clang-tools-extra/trun
ayartsev added inline comments.
Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:746
@@ -739,1 +745,3 @@
+return static_cast(this)->hasTrait(MR, IK);
+ }
};
Hmm.. Either we completely encapsulate 'RegionAndSymbolInvalidationTraits' in
the 'invalidateRegi
Author: djasper
Date: Fri Aug 14 08:39:57 2015
New Revision: 245048
URL: http://llvm.org/viewvc/llvm-project?rev=245048&view=rev
Log:
misc-unused-parameters: Fix crasher with C forward declarations that
can leave out the parameter list.
Modified:
clang-tools-extra/trunk/clang-tidy/misc/Unused
Author: davide
Date: Fri Aug 14 09:13:29 2015
New Revision: 245051
URL: http://llvm.org/viewvc/llvm-project?rev=245051&view=rev
Log:
[Sema] main can't be declared as global variable, in C++.
So, we now reject that. We also warn for any external-linkage global
variable named main in C, because it
davide added a comment.
Oops, I uploaded the wrong diff. Anyway, I changed can't to cannot and
committed this as r245051.
While looking at DiagnosticSemaKind.td I noticed there are still 7 diagnostics
that use can't instead of cannot. Are you OK if I change those? (in a
subsequent commit, of co
Author: alexfh
Date: Fri Aug 14 09:31:31 2015
New Revision: 245052
URL: http://llvm.org/viewvc/llvm-project?rev=245052&view=rev
Log:
[clang-tidy] Move IncludeSorter.* and IncludeInserter.* to clang-tidy/utils/
This is better structurally and it also fixes a linker error in the configure
build.
A
Author: majnemer
Date: Fri Aug 14 09:43:50 2015
New Revision: 245054
URL: http://llvm.org/viewvc/llvm-project?rev=245054&view=rev
Log:
[ASTContext] Call APValue destructors for MaterializedTemporaryValues
Hopefully this makes the sanitizer build bot happy.
Modified:
cfe/trunk/lib/AST/ASTCont
andreybokhanko added a comment.
John,
> Make sense?
Yes, absolutely! -- even for me. :-)
Thanks a 100!
Yours,
Andrey
http://reviews.llvm.org/D11297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
alexfh added a comment.
What's the status of this patch?
http://reviews.llvm.org/D9285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
What's the status of this patch?
http://reviews.llvm.org/D9286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245063: Represent 2 parallel string arrays as one
string[][2] array. (authored by dougk).
Changed prior to commit:
http://reviews.llvm.org/D11991?vs=31977&id=32157#toc
Repository:
rL LLVM
http://rev
Author: dougk
Date: Fri Aug 14 10:52:12 2015
New Revision: 245063
URL: http://llvm.org/viewvc/llvm-project?rev=245063&view=rev
Log:
Represent 2 parallel string arrays as one string[][2] array.
Differential Revision: http://reviews.llvm.org/D11991
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
On Fri, Aug 14, 2015 at 5:25 AM, Alexey Bataev via cfe-commits
wrote:
> Author: abataev
> Date: Fri Aug 14 07:25:37 2015
> New Revision: 245041
>
> URL: http://llvm.org/viewvc/llvm-project?rev=245041&view=rev
> Log:
> [OPENMP] Fix for http://llvm.org/PR24371: Assert failure compiling blender
> 2.
alexfh added a comment.
Sorry for the delay. A few more comments, otherwise looks really nice.
Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:166
@@ +165,3 @@
+ static llvm::Regex Splitter(
+ "(([a-z0-9A-Z]*)(_+)|([A-Z]?[a-z0-9]+)([A-Z]|$)|([A-Z]+)([A-Z]|$))"
Yes, I got confused when clang is in C++ mode. In my patch, I was checking the
driver status, but that’s not the complete story. From these combinations of
invoking clang with some input:
./clang[++] [-x [c | c++]] myinput.[TY_C | TY_CXX]
I wanted to create a special case for these combinations
martell created this revision.
martell added a reviewer: rnk.
martell added subscribers: compnerd, cfe-commits.
Herald added subscribers: rengolin, aemerson.
MSDN says that fastcall stdcall and thiscall and vectorcall are all accepted
but ignored on ARM and X64
https://msdn.microsoft.com/en-us/l
rnk added inline comments.
Comment at: test/Parser/arm-windows-calling-convention-handling.c:2
@@ -1,3 @@
-// RUN: %clang_cc1 -triple thumbv7-windows -fms-compatibility -fsyntax-only
-verify %s
-
-int __cdecl cdecl(int a, int b, int c, int d) { // expected-warning {{calling
conv
martell added inline comments.
Comment at: test/Parser/arm-windows-calling-convention-handling.c:2
@@ -1,3 @@
-// RUN: %clang_cc1 -triple thumbv7-windows -fms-compatibility -fsyntax-only
-verify %s
-
-int __cdecl cdecl(int a, int b, int c, int d) { // expected-warning {{calling
rnk added inline comments.
Comment at: test/Parser/arm-windows-calling-convention-handling.c:2
@@ -1,3 @@
-// RUN: %clang_cc1 -triple thumbv7-windows -fms-compatibility -fsyntax-only
-verify %s
-
-int __cdecl cdecl(int a, int b, int c, int d) { // expected-warning {{calling
conv
beanz created this revision.
beanz added reviewers: bogner, echristo.
beanz added a subscriber: cfe-commits.
The code comments in the Makefile indicate this was put in place to support
issues when building clang with GCC. Today clang's strict aliasing works, so we
shouldn't pass -fno-strict-alia
beanz updated this revision to Diff 32163.
beanz added a comment.
Should have been calling $(CC) not cc in the makefile. Oops.
http://reviews.llvm.org/D12036
Files:
CMakeLists.txt
Makefile
Index: Makefile
===
--- Makefile
+++
Hi,
On Fri, Aug 14, 2015 at 5:31 PM, Alexander Kornienko via cfe-commits
wrote:
> Author: alexfh
> Date: Fri Aug 14 09:31:31 2015
> New Revision: 245052
>
> URL: http://llvm.org/viewvc/llvm-project?rev=245052&view=rev
> Log:
> [clang-tidy] Move IncludeSorter.* and IncludeInserter.* to clang-tidy/
martell updated this revision to Diff 32164.
martell added a comment.
updated to reflect rnk comments
http://reviews.llvm.org/D12034
Files:
lib/Basic/Targets.cpp
test/Parser/arm-windows-calling-convention-handling.c
test/Parser/x64-windows-calling-convention-handling.c
Index: test/Parser
Strange. No build bots complained about this so far. I'll take a look at
this in an hour or so.
On 14 Aug 2015 19:42, "İsmail Dönmez" wrote:
> Hi,
>
> On Fri, Aug 14, 2015 at 5:31 PM, Alexander Kornienko via cfe-commits
> wrote:
> > Author: alexfh
> > Date: Fri Aug 14 09:31:31 2015
> > New Revis
This is fine, but would you mind moving it to the cmake and autoconf checks
respectively? Probably near the warning checks where we already check for
compiler.
On Fri, Aug 14, 2015, 10:41 AM Chris Bieneman wrote:
> beanz updated this revision to Diff 32163.
> beanz added a comment.
>
> Should ha
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245076: Windows ARM: ignore calling conventions as described
on MSDN (authored by martell).
Changed prior to commit:
http://reviews.llvm.org/D12034?vs=32164&id=32166#toc
Repository:
rL LLVM
http://r
Author: martell
Date: Fri Aug 14 13:00:09 2015
New Revision: 245076
URL: http://llvm.org/viewvc/llvm-project?rev=245076&view=rev
Log:
Windows ARM: ignore calling conventions as described on MSDN
Summary:
MSDN says that fastcall, stdcall, thiscall, and vectorcall are all
accepted but ignored on AR
Have you tested this? I assume there are strict aliasing violations in
Clang/LLVM if we've had this turned on for a while.
(does strict aliasing still have the special case for enum type punning?
Becaues I've certainly seen (& fixed) that in a few places in Clang/LLVM)
On Fri, Aug 14, 2015 at 10:
- Original Message -
> From: "Eric Christopher via cfe-commits"
> To: reviews+d12036+public+3cb5bf37e2ab4...@reviews.llvm.org,
> m...@justinbogner.com
> Cc: cfe-commits@lists.llvm.org
> Sent: Friday, August 14, 2015 12:50:09 PM
> Subject: Re: [PATCH] D12036: We shouldn't need to pass -fno
beanz added a comment.
dblaikie,
I've run this through check-all with no issues.
http://reviews.llvm.org/D12036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
I'm OK with it if Richard gives owner's approval.
Cheers,
Hans
On Thu, Aug 13, 2015 at 8:27 PM, Martell Malone wrote:
> Hi Hans,
>
> Is this bugfix something that can be merged into 3.7 ?
>
> Kind Regards
> Martell
>
> On Thu, Aug 13, 2015 at 4:42 PM, Martell Malone
> wrote:
>>
>> This revision
On Fri, Aug 14, 2015 at 2:09 AM, John McCall wrote:
>> On Aug 10, 2015, at 12:40 PM, Hans Wennborg wrote:
>> On Fri, Aug 7, 2015 at 11:57 AM, Simon Pilgrim
>> wrote:
>>> On 06/08/2015 18:05, Hans Wennborg wrote:
On Sun, Aug 2, 2015 at 8:28 AM, Simon Pilgrim
wrote:
>
> Au
beanz added a comment.
echristo,
I can move the makefile check to the autoconf check, but I think setting the
flags should stay in the clang CMakeLists/Makefile otherwise it will change
behavior. Today we only enable this flag for the clang subdirectory, not all of
LLVM.
Thoughts?
http://re
Chris Bieneman writes:
> beanz added a comment.
>
> dblaikie,
>
> I've run this through check-all with no issues.
Might want to bootstrap with sanitizers or something. Strict aliasing
related bugs can be subtle.
___
cfe-commits mailing list
cfe-commits@
dcoughlin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp:68
@@ +67,3 @@
+ // Methods that require a localized string
+ mutable llvm::StringMap> UIMethods;
+ // Methods that return a localized string
FWIW,
#include "
On Tue, Aug 11, 2015 at 1:41 PM, Hans Wennborg wrote:
> On Thu, Aug 6, 2015 at 1:56 PM, David Majnemer via cfe-commits
> wrote:
>> Author: majnemer
>> Date: Thu Aug 6 15:56:55 2015
>> New Revision: 244266
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=244266&view=rev
>> Log:
>> [ItaniumCXXAB
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D12037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pcc created this revision.
pcc added a reviewer: rsmith.
pcc added subscribers: cfe-commits, Prazek.
This function can be used to create a metadata identifier for a specific
type. No functionality change, but this will be used by D11857 and D12026.
http://reviews.llvm.org/D12038
Files:
lib/Cod
Author: rnk
Date: Fri Aug 14 14:03:02 2015
New Revision: 245083
URL: http://llvm.org/viewvc/llvm-project?rev=245083&view=rev
Log:
Don't run explicit-modules-missing-files.cpp on Windows
It is flaky due to inability to remove files with open handles. We
could paper over it with rm -f, but then th
Author: martell
Date: Fri Aug 14 14:05:56 2015
New Revision: 245084
URL: http://llvm.org/viewvc/llvm-project?rev=245084&view=rev
Log:
WindowsX86: long double is x87DoubleExtended on mingw
Summary:
long double on x86 mingw is 80bits and is aligned to 16bytes
Fixes:
https://llv
martell added a comment.
Landed in http://reviews.llvm.org/rL245084
The commit parser is bugged :/
http://reviews.llvm.org/D12037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman updated this revision to Diff 32175.
aaron.ballman added a comment.
Updated the patch to handle member initializers as well as base class
initializers. This changes the name of things from "base" to "init" as well.
http://reviews.llvm.org/D11784
Files:
clang-tidy/misc/CMakeList
kulpreet updated this revision to Diff 32174.
kulpreet added a comment.
- Incorporated feedback from Devin's review
- Moved LSM over to StringSet<>
http://reviews.llvm.org/D11572
Files:
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/C
martell added a comment.
Hans this is something we most definitely should have in 3.7
It's a pretty big bugfix for this target :)
http://reviews.llvm.org/D12037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
xazax.hun added a comment.
Addressed the suggestions.
Comment at: lib/StaticAnalyzer/Checkers/ObjCGenericsChecker.cpp:257
@@ +256,3 @@
+// However a downcast may also lose information. E. g.:
+// MutableMap : Map
+// The downcast to mutable map loses the informatio
I'm OK with it if Richard gives owner's approval.
Cheers,
Hans
On Fri, Aug 14, 2015 at 12:25 PM, Martell Malone
wrote:
> martell added a comment.
>
> Hans this is something we most definitely should have in 3.7
> It's a pretty big bugfix for this target :)
>
>
> http://reviews.llvm.org/D12037
>
hans added a comment.
I'm OK with it if Richard gives owner's approval.
Cheers,
Hans
http://reviews.llvm.org/D12037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: zaks
Date: Fri Aug 14 15:22:22 2015
New Revision: 245093
URL: http://llvm.org/viewvc/llvm-project?rev=245093&view=rev
Log:
[analyzer] Add checkers for OS X / iOS localizability issues
Add checkers that detect code-level localizability issues for OS X / iOS:
- A path sensitive checker th
(+ the new cfe-commits list; sorry for the spam)
On Fri, Aug 14, 2015 at 1:25 PM, Hans Wennborg wrote:
> Reid and Nico suggested this should be merged to 3.7 together with
> r244468 as it fixes an issue with libc++ when compiled with Clang on
> x86_64 Android.
>
> John, you're the CodeGen owner.
ehsan added a comment.
Sorry, I kind of dropped the ball here!
At Mozilla we ended up deciding on allowing only a maximum of one of virtual,
final or override per function declaration, similar to the Google coding style,
so we won't need the KeepVirtual option. Should I still add it neverthele
ehsan added a comment.
I should land this, but let's wait to see if we want
http://reviews.llvm.org/D9285 or not, since this patch is built on top of it.
If not, I can rebase it on top of master as well.
http://reviews.llvm.org/D9286
___
cfe-comm
pcc updated this revision to Diff 32179.
pcc added a comment.
Rebase onto http://reviews.llvm.org/D12038
http://reviews.llvm.org/D11857
Files:
docs/ControlFlowIntegrity.rst
include/clang/AST/Mangle.h
include/clang/Basic/Sanitizers.def
lib/AST/ItaniumMangle.cpp
lib/AST/MicrosoftMangle.
jfb added inline comments.
Comment at: lib/Basic/Targets.cpp:6938
@@ +6937,3 @@
+BigEndian = false;
+NoAsmVariants = true;
+SuitableAlign = 128;
True, leaving it as is sgtm.
Comment at: lib/Basic/Targets.cpp:6994
@@ +6993,3 @@
+#inclu
On Fri, Aug 14, 2015 at 1:55 PM, John McCall wrote:
>> On Aug 14, 2015, at 1:25 PM, Hans Wennborg wrote:
>> Reid and Nico suggested this should be merged to 3.7 together with
>> r244468 as it fixes an issue with libc++ when compiled with Clang on
>> x86_64 Android.
>>
>> John, you're the CodeGen
Ok… I wrote some CMake goop to enable sanitizers on a bootstrap build (I’ll
clean up the patches and send those out separately). check-clang worked with
asan and ubsan enabled.
Is that sufficient pre-commit testing?
I still need to rework the Makefile side of the patch to match Eric’s
suggesti
sunfish updated this revision to Diff 32192.
sunfish marked an inline comment as done.
sunfish added a comment.
- set MaxAtomicInlineWidth to 0 for now (sets *_ATOMIC_*_LOCK_FREE to 1)
- enable LargeArrayAlign
- enable __int128
- various cleanups
Repository:
rL LLVM
http://reviews.llvm.org/D1
sunfish added inline comments.
Comment at: lib/Basic/Targets.cpp:7010
@@ +7009,3 @@
+ { #ID, TYPE, ATTRS, HEADER, ALL_LANGUAGES, nullptr },
+#include "clang/Basic/BuiltinsWebAssembly.def"
+};
WebAssembly32TargetInfo is subclassed in LLVM code, and getTargetDefine
Sorry for the delay, this LGTM for branch.
On Wed, Aug 12, 2015 at 1:09 AM, AlexDenisov <1101.deb...@gmail.com> wrote:
> Ping
> --
> AlexDenisov
> Software Engineer, http://lowlevelbits.org
>
> > On 06 Aug 2015, at 18:15, Hans Wennborg wrote:
> >
> > Hi Alex,
> >
> > What crash is that? I don't
rsmith added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:4700-4703
@@ +4699,6 @@
+if (Member->getAttr()) {
+ if (TSK == TSK_ExplicitInstantiationDeclaration)
+// Don't go any further if this is just an explicit instantiation
+// declaration.
+
Thanks! r245116.
On Fri, Aug 14, 2015 at 3:30 PM, Richard Smith wrote:
> Sorry for the delay, this LGTM for branch.
>
>
> On Wed, Aug 12, 2015 at 1:09 AM, AlexDenisov <1101.deb...@gmail.com> wrote:
>>
>> Ping
>> --
>> AlexDenisov
>> Software Engineer, http://lowlevelbits.org
>>
>> > On 06 Aug 201
nwilson added a comment.
Ping
http://reviews.llvm.org/D11789
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nwilson
Date: Fri Aug 14 18:19:32 2015
New Revision: 245123
URL: http://llvm.org/viewvc/llvm-project?rev=245123&view=rev
Log:
[CONCEPTS] Add diagnostic; invalid tag when concept specified
Summary: Adding check to emit diagnostic for invalid tag when concept is
specified and associated te
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245123: [CONCEPTS] Add diagnostic; invalid tag when concept
specified (authored by nwilson).
Changed prior to commit:
http://reviews.llvm.org/D11916?vs=31957&id=32200#toc
Repository:
rL LLVM
http://
Author: nmusgrave
Date: Fri Aug 14 18:22:03 2015
New Revision: 245124
URL: http://llvm.org/viewvc/llvm-project?rev=245124&view=rev
Log:
clarified test comment
Modified:
cfe/trunk/test/CodeGenCXX/sanitize-dtor-callback.cpp
Modified: cfe/trunk/test/CodeGenCXX/sanitize-dtor-callback.cpp
URL:
h
hans updated the summary for this revision.
hans updated this revision to Diff 32201.
hans marked an inline comment as done.
hans added a comment.
Addressed comments.
http://reviews.llvm.org/D11850
Files:
include/clang/Sema/Sema.h
lib/Parse/ParseDeclCXX.cpp
lib/Sema/Sema.cpp
lib/Sema/Se
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D11850
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
rsmith added inline comments.
Comment at: include/clang/Sema/DeclSpec.h:1262
@@ -1260,1 +1261,3 @@
+/// \brief The end location of the exception specifier, if any.
+unsigned ExceptionSpecLocEnd;
nwilson wrote:
> Please let me know if there is still an is
On Fri, Aug 14, 2015 at 7:15 AM, Davide Italiano
wrote:
> davide added a comment.
>
> Oops, I uploaded the wrong diff. Anyway, I changed can't to cannot and
> committed this as r245051.
> While looking at DiagnosticSemaKind.td I noticed there are still 7
> diagnostics that use can't instead of ca
rsmith added a subscriber: rsmith.
Comment at: lib/AST/ExprConstant.cpp:6221-6223
@@ +6220,5 @@
+ //
+ // extern struct X { char buff[32]; int a, b, c; } *p;
+ // int a = __builtin_object_size(p->buff + 4, 3); // returns 28
+ // int b = __builtin_object_size(p->buff + 4,
dcoughlin added a comment.
You should consider what should happen when the memcpy may write past the end
of the fixed-size array and add tests that specify correct behavior for these
cases. An important example is:
struct Foo {
char data[4];
int i;
};
Foo f;
f.i = 10;
me
zaks.anna added a comment.
Committed earlier today in r245093.
Thank you for contributing the checker!
http://reviews.llvm.org/D11572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Fri Aug 14 19:34:15 2015
New Revision: 245136
URL: http://llvm.org/viewvc/llvm-project?rev=245136&view=rev
Log:
[modules] Stop dropping 'module.timestamp' files into the current directory
when building with implicit modules disabled.
Added:
cfe/trunk/test/Modules/explicit
jfb accepted this revision.
jfb added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/Basic/Targets.cpp:7002
@@ +7001,3 @@
+ bool isCLZForZeroUndef() const override final { return false; }
+ bool hasInt128Type() const override final { return tr
1 - 100 of 122 matches
Mail list logo
