alexfh added a comment. A high level question: why is this check specific to base class initialization? Isn't the same issue possible when initializing members, for example? What would change if in your example `D` would have a member of type `B` instead of deriving from it?
> One thing I am not certain of in this patch is how to test it. I have some > rudimentary tests, but am unable to test the "note:" diagnostics from > FileCheck (attempting to add any cause the "warning:" diagnostics to not be > found). Can you give an example of what you do and what results do you get? > I suspect this is why clang-tidy.sh exists, but unfortunately, that means the > tests will not be run on Windows (which is the platform I am > developing on). Suggestions on how to improve the tests are welcome, but for > now, I'm not testing the note diagnostics. Converting the script to python seems like the most universal approach. Should be trivial with the `sh` python package, but I'm not sure whether we can rely on it being installed. http://reviews.llvm.org/D11784 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
