Thanks Richard!
> On Jul 8, 2019, at 12:46 PM, Richard Smith via cfe-commits
> wrote:
>
> Committed as r365377.
>
> On Mon, 8 Jul 2019 at 12:43, Kristóf Umann via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
> Thank you so much! Sorry for the inconvencience, I'll be that much more
Committed as r365377.
On Mon, 8 Jul 2019 at 12:43, Kristóf Umann via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Thank you so much! Sorry for the inconvencience, I'll be that much more
> careful next time :)
>
=) No worries. It's one of those pesky "no diagnostic required" cases;
they're
Thank you so much! Sorry for the inconvencience, I'll be that much more
careful next time :)
On Mon, 8 Jul 2019, 21:42 Richard Smith, wrote:
> I'll commit the change below once my testing finishes :)
>
> On Mon, 8 Jul 2019 at 12:40, Kristóf Umann via cfe-commits <
> cfe-commits@lists.llvm.org> w
I'll commit the change below once my testing finishes :)
On Mon, 8 Jul 2019 at 12:40, Kristóf Umann via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Noted, thanks! Gabor, could you please fix this?
>
> On Mon, 8 Jul 2019, 21:37 Richard Smith, wrote:
>
>> This is in any case the wrong fix.
Noted, thanks! Gabor, could you please fix this?
On Mon, 8 Jul 2019, 21:37 Richard Smith, wrote:
> This is in any case the wrong fix. The code *is* wrong, for the reason
> this compiler is reporting.
>
> The correct fix is to declare the explicit specializations in the header
> file:
>
> templat
This is in any case the wrong fix. The code *is* wrong, for the reason this
compiler is reporting.
The correct fix is to declare the explicit specializations in the header
file:
template <> void CFGDominatorTreeImpl::anchor();
template <> void CFGDominatorTreeImpl::anchor();
Clang will tell you
Hi!
Unfortunately, I'm out of town for the week -- I'll see whether I can ask
someone in the office to help out with this.
On Mon, 8 Jul 2019, 21:29 JF Bastien, wrote:
> Kristof,
>
> It looks like your fix didn’t address all the bots:
>
> /Users/buildslave/jenkins/workspace/clang-stage2-coverag
Kristof,
It looks like your fix didn’t address all the bots:
/Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/tools/clang/lib/Analysis/Dominators.cpp:14:48:
error: explicit specialization of 'anchor' after instantiation
void CFGDominatorTreeImpl::anchor() {}
Author: szelethus
Date: Wed Jul 3 05:06:10 2019
New Revision: 365030
URL: http://llvm.org/viewvc/llvm-project?rev=365030&view=rev
Log:
Make a buildbot using a buggy gcc happy
When specializing a template in a namespace, it has to be in a namespace
block, else gcc will get confused. Hopefully thi
