Just catching up on this now.
r319363 looks good to me, It makes little sense to use GNU SEH in that case.
My remaining concern is mostly about why we still need the workaround for
> x86 in the function getting the default (returning None instead of WinEH
> for that case). But as long as this work
On Wed, 29 Nov 2017, Martin Storsjö via cfe-commits wrote:
On Wed, 29 Nov 2017, Reid Kleckner wrote:
On Wed, Nov 29, 2017 at 12:21 PM, Martin Storsjö wrote:
On Wed, 29 Nov 2017, Martell Malone via cfe-commits wrote:
Thanks for letting me know Reid.
I’ll in work a
On Wed, 29 Nov 2017, Reid Kleckner wrote:
On Wed, Nov 29, 2017 at 12:21 PM, Martin Storsjö wrote:
On Wed, 29 Nov 2017, Martell Malone via cfe-commits wrote:
Thanks for letting me know Reid.
I’ll in work and won’t be able to access the repo
until lunch t
On Wed, Nov 29, 2017 at 12:21 PM, Martin Storsjö wrote:
> On Wed, 29 Nov 2017, Martell Malone via cfe-commits wrote:
>
>> Thanks for letting me know Reid.
>> I’ll in work and won’t be able to access the repo until lunch time. (~3
>> hours)
>> Feel free to revert if it is not trivial.
>>
>> The ea
On Wed, 29 Nov 2017, Martell Malone via cfe-commits wrote:
Thanks for letting me know Reid.
I’ll in work and won’t be able to access the repo until lunch time. (~3
hours)
Feel free to revert if it is not trivial.
The easy fix might be to change to == x86_64 from != x86 For is Windows in
the def
Thanks for letting me know Reid.
I’ll in work and won’t be able to access the repo until lunch time. (~3
hours)
Feel free to revert if it is not trivial.
The easy fix might be to change to == x86_64 from != x86 For is Windows in
the default toolchain. That should restore the old behavior.
I’m cur
I see a bunch of link errors that suggest we're using the wrong EH
personality in MSVC mode now:
FAILED: win_clang_nacl_win64/swiftshader/libEGL.dll
win_clang_nacl_win64/swiftshader/libEGL.dll.lib
win_clang_nacl_win64/swiftshader/libEGL.dll.pdb
C:/b/depot_tools/win_tools-2_7_6_bin/python/bin/pytho
Author: martell
Date: Tue Nov 28 23:25:12 2017
New Revision: 319297
URL: http://llvm.org/viewvc/llvm-project?rev=319297&view=rev
Log:
Toolchain: Normalize dwarf, sjlj and seh eh
This is a re-apply of r319294.
adds -fseh-exceptions and -fdwarf-exceptions flags
clang will check if the user has sp
