Ah, I see - your follow up in 285950 mentions that this unique_ptr was
always null, so none of it really mattered/did anything.
On Tue, Nov 8, 2016 at 11:42 AM David Blaikie wrote:
> On Thu, Nov 3, 2016 at 10:52 AM Chandler Carruth via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> Autho
On Thu, Nov 3, 2016 at 10:52 AM Chandler Carruth via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: chandlerc
> Date: Thu Nov 3 12:42:32 2016
> New Revision: 285946
>
> URL: http://llvm.org/viewvc/llvm-project?rev=285946&view=rev
> Log:
> Using release to free memory is at best confus
Author: chandlerc
Date: Thu Nov 3 12:42:32 2016
New Revision: 285946
URL: http://llvm.org/viewvc/llvm-project?rev=285946&view=rev
Log:
Using release to free memory is at best confusing -- one would expect
that its result is in fact used. Instead, use reset.
This was pointed out by PVS-Studio.
M
