Re: r261297 - Implement the likely resolution of core issue 253.

2016-02-24 Thread Nico Weber via cfe-commits
On Wed, Feb 24, 2016 at 3:53 PM, Richard Smith wrote: > On Wed, Feb 24, 2016 at 10:47 AM, Nico Weber wrote: > > Thanks for patiently explaining this. The attached patch is your email in > > diff form. Does this look alright? > > Yes, it looks great. Thanks for the excellent test cases. > r26177

Re: r261297 - Implement the likely resolution of core issue 253.

2016-02-24 Thread Richard Smith via cfe-commits
On Wed, Feb 24, 2016 at 10:47 AM, Nico Weber wrote: > Thanks for patiently explaining this. The attached patch is your email in > diff form. Does this look alright? Yes, it looks great. Thanks for the excellent test cases. > Since you mention C++98: We emit this diagnostic in C++98 mode (before

Re: r261297 - Implement the likely resolution of core issue 253.

2016-02-24 Thread Nico Weber via cfe-commits
Thanks for patiently explaining this. The attached patch is your email in diff form. Does this look alright? Since you mention C++98: We emit this diagnostic in C++98 mode (before and after my change). The rule is new in C+++11, right? Should I add a check for CPlusPlus11 before emitting this diag

Re: r261297 - Implement the likely resolution of core issue 253.

2016-02-23 Thread Richard Smith via cfe-commits
On Sat, Feb 20, 2016 at 6:53 AM, Nico Weber wrote: > On Fri, Feb 19, 2016 at 10:32 PM, Nico Weber wrote: >> >> On Fri, Feb 19, 2016 at 10:02 PM, Nico Weber wrote: >>> >>> On Fri, Feb 19, 2016 at 8:01 PM, Richard Smith >>> wrote: On Fri, Feb 19, 2016 at 4:41 PM, Nico Weber wrote:

Re: r261297 - Implement the likely resolution of core issue 253.

2016-02-20 Thread Nico Weber via cfe-commits
On Fri, Feb 19, 2016 at 10:32 PM, Nico Weber wrote: > On Fri, Feb 19, 2016 at 10:02 PM, Nico Weber wrote: > >> On Fri, Feb 19, 2016 at 8:01 PM, Richard Smith >> wrote: >> >>> On Fri, Feb 19, 2016 at 4:41 PM, Nico Weber wrote: >>> > On Fri, Feb 19, 2016 at 4:29 PM, Richard Smith via cfe-commits

Re: r261297 - Implement the likely resolution of core issue 253.

2016-02-19 Thread Nico Weber via cfe-commits
On Fri, Feb 19, 2016 at 10:02 PM, Nico Weber wrote: > On Fri, Feb 19, 2016 at 8:01 PM, Richard Smith > wrote: > >> On Fri, Feb 19, 2016 at 4:41 PM, Nico Weber wrote: >> > On Fri, Feb 19, 2016 at 4:29 PM, Richard Smith via cfe-commits >> > wrote: >> >> >> >> On Thu, Feb 18, 2016 at 5:52 PM, Nic

Re: r261297 - Implement the likely resolution of core issue 253.

2016-02-19 Thread Nico Weber via cfe-commits
On Fri, Feb 19, 2016 at 8:01 PM, Richard Smith wrote: > On Fri, Feb 19, 2016 at 4:41 PM, Nico Weber wrote: > > On Fri, Feb 19, 2016 at 4:29 PM, Richard Smith via cfe-commits > > wrote: > >> > >> On Thu, Feb 18, 2016 at 5:52 PM, Nico Weber via cfe-commits > >> wrote: > >> > Author: nico > >> >

Re: r261297 - Implement the likely resolution of core issue 253.

2016-02-19 Thread Richard Smith via cfe-commits
On Fri, Feb 19, 2016 at 4:41 PM, Nico Weber wrote: > On Fri, Feb 19, 2016 at 4:29 PM, Richard Smith via cfe-commits > wrote: >> >> On Thu, Feb 18, 2016 at 5:52 PM, Nico Weber via cfe-commits >> wrote: >> > Author: nico >> > Date: Thu Feb 18 19:52:46 2016 >> > New Revision: 261297 >> > >> > URL:

Re: r261297 - Implement the likely resolution of core issue 253.

2016-02-19 Thread Nico Weber via cfe-commits
On Fri, Feb 19, 2016 at 4:29 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Thu, Feb 18, 2016 at 5:52 PM, Nico Weber via cfe-commits > wrote: > > Author: nico > > Date: Thu Feb 18 19:52:46 2016 > > New Revision: 261297 > > > > URL: http://llvm.org/viewvc/llvm-project?

Re: r261297 - Implement the likely resolution of core issue 253.

2016-02-19 Thread Richard Smith via cfe-commits
On Thu, Feb 18, 2016 at 5:52 PM, Nico Weber via cfe-commits wrote: > Author: nico > Date: Thu Feb 18 19:52:46 2016 > New Revision: 261297 > > URL: http://llvm.org/viewvc/llvm-project?rev=261297&view=rev > Log: > Implement the likely resolution of core issue 253. > > C++11 requires const objects to

Re: r261297 - Implement the likely resolution of core issue 253.

2016-02-19 Thread Nico Weber via cfe-commits
If you merge this, you also need to merge the small follow up "r261301 - Fix SemaTemplate/instantiate-field.cpp after r261297." On Feb 19, 2016 11:26 AM, "Hans Wennborg via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > On Fri, Feb 19, 2016 at 4:00 AM, Ismail Donmez via cfe-commits > wrote:

Re: r261297 - Implement the likely resolution of core issue 253.

2016-02-19 Thread Hans Wennborg via cfe-commits
On Fri, Feb 19, 2016 at 4:00 AM, Ismail Donmez via cfe-commits wrote: > On Fri, Feb 19, 2016 at 3:52 AM, Nico Weber via cfe-commits > wrote: >> Author: nico >> Date: Thu Feb 18 19:52:46 2016 >> New Revision: 261297 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=261297&view=rev >> Log: >> Impl

Re: r261297 - Implement the likely resolution of core issue 253.

2016-02-19 Thread Ismail Donmez via cfe-commits
Hi, On Fri, Feb 19, 2016 at 3:52 AM, Nico Weber via cfe-commits wrote: > Author: nico > Date: Thu Feb 18 19:52:46 2016 > New Revision: 261297 > > URL: http://llvm.org/viewvc/llvm-project?rev=261297&view=rev > Log: > Implement the likely resolution of core issue 253. > > C++11 requires const objec

r261297 - Implement the likely resolution of core issue 253.

2016-02-18 Thread Nico Weber via cfe-commits
Author: nico Date: Thu Feb 18 19:52:46 2016 New Revision: 261297 URL: http://llvm.org/viewvc/llvm-project?rev=261297&view=rev Log: Implement the likely resolution of core issue 253. C++11 requires const objects to have a user-provided constructor, even for classes without any fields. DR 253 relax