On 2/7/17 7:30 PM, Saleem Abdulrasool wrote:
On Tue, Feb 7, 2017 at 1:09 PM, Jonathan Roelofs
mailto:jonat...@codesourcery.com>> wrote:
On 1/24/17 8:10 PM, Saleem Abdulrasool via cfe-commits wrote:
Don't use the cast for the check, use isa. Although, since
you use t
On Tue, Feb 7, 2017 at 1:09 PM, Jonathan Roelofs
wrote:
>
>
> On 1/24/17 8:10 PM, Saleem Abdulrasool via cfe-commits wrote:
>
>> Don't use the cast for the check, use isa. Although, since you use the
>> value later, it is probably better to write this as:
>>
>> if (const auto *RD = cast(CurC
On 1/24/17 8:10 PM, Saleem Abdulrasool via cfe-commits wrote:
Don't use the cast for the check, use isa. Although, since you use the
value later, it is probably better to write this as:
if (const auto *RD = cast(CurContext))
CheckShadowInheritedVariabless(Loc, Name.getAsString(), RD
*James Sun
> *Date: *Saturday, February 4, 2017 at 11:35 PM
>
> *To: *Richard Smith
> *Cc: *Saleem Abdulrasool , "
> cfe-commits@lists.llvm.org" , Aaron Ballman <
> aa...@aaronballman.com>
> *Subject: *Re: Add warning for c++ member variable shadowing
>
>
on Ballman
Subject: Re: Add warning for c++ member variable shadowing
Thanks Richard! Hopefully this is the last patch :D
Could you please help me to commit it maybe?
Thanks
James
From: on behalf of Richard Smith
Date: Saturday, February 4, 2017 at 10:43 PM
To: James Sun
Cc: Saleem Abdulras
Cc: Saleem Abdulrasool mailto:compn...@compnerd.org>>,
"cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>"
mailto:cfe-commits@lists.llvm.org>>, Aaron Ballman
mailto:aa...@aaronballman.com>>
Subject: Re: Add warning for c++ member variable shad
commit for you?
On 4 February 2017 at 22:21, James Sun wrote:
> oops
>
>
>
> *From: *James Sun
> *Date: *Saturday, February 4, 2017 at 9:19 PM
>
> *To: *Richard Smith
> *Cc: *Saleem Abdulrasool , "
> cfe-commits@lists.llvm.org" , Aaron Ballman <
>
oops
From: James Sun
Date: Saturday, February 4, 2017 at 9:19 PM
To: Richard Smith
Cc: Saleem Abdulrasool , "cfe-commits@lists.llvm.org"
, Aaron Ballman
Subject: Re: Add warning for c++ member variable shadowing
updated
From: James Sun
Date: Saturday, February 4, 2017 at
updated
From: James Sun
Date: Saturday, February 4, 2017 at 6:52 PM
To: Richard Smith
Cc: Saleem Abdulrasool , "cfe-commits@lists.llvm.org"
, Aaron Ballman
Subject: Re: Add warning for c++ member variable shadowing
Ok I get your point. Suppose there are two paths from class B to ba
;cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>"
mailto:cfe-commits@lists.llvm.org>>, Aaron Ballman
mailto:aa...@aaronballman.com>>
Subject: Re: Add warning for c++ member variable shadowing
Thanks, James! I think I have only one more substantive comment:
+ (F
ailto:james...@fb.com>>
Cc: Saleem Abdulrasool mailto:compn...@compnerd.org>>,
"cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>"
mailto:cfe-commits@lists.llvm.org>>, Aaron Ballman
mailto:aa...@aaronballman.com>>
Subject: Re: Add warning for
1:59 AM
> *To: *James Sun
> *Cc: *Saleem Abdulrasool , "
> cfe-commits@lists.llvm.org" , Aaron Ballman <
> aa...@aaronballman.com>
> *Subject: *Re: Add warning for c++ member variable shadowing
>
>
>
> Thanks, James! I think I have only one more substa
Thanks Richard! Good catch! The updated version is attached. --James
From: on behalf of Richard Smith
Date: Thursday, February 2, 2017 at 11:59 AM
To: James Sun
Cc: Saleem Abdulrasool , "cfe-commits@lists.llvm.org"
, Aaron Ballman
Subject: Re: Add warning for c++ member variable
.@metafoo.co.uk>
> *Date: *Wednesday, February 1, 2017 at 3:50 PM
> *To: *James Sun
>
> *Cc: *Saleem Abdulrasool , "
> cfe-commits@lists.llvm.org" , Aaron Ballman <
> aa...@aaronballman.com>
> *Subject: *Re: Add warning for c++ member variable shadowing
>
&g
ary 31, 2017 at 6:53 PM
To: James Sun mailto:james...@fb.com>>
Cc: Richard Smith mailto:rich...@metafoo.co.uk>>,
"cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>"
mailto:cfe-commits@lists.llvm.org>>, Aaron Ballman
mailto:aa...@aaronballman.com>>
for the late reply. Thank you for giving the feedback! The updated
> version is attached. Please let me know if there is anything improper.
>
>
>
> Thanks
>
>
>
> James
>
>
>
> *From: * on behalf of Richard Smith <
> rich...@metafoo.co.uk>
> *Date: *
Fixed!
From: Saleem Abdulrasool
Date: Tuesday, January 31, 2017 at 6:53 PM
To: James Sun
Cc: Richard Smith , "cfe-commits@lists.llvm.org"
, Aaron Ballman
Subject: Re: Add warning for c++ member variable shadowing
Hmm, the braces in the if (bases.find(...)...) are not needed.
Coul
; *From: * on behalf of Richard Smith <
> rich...@metafoo.co.uk>
> *Date: *Friday, January 27, 2017 at 3:03 PM
> *To: *James Sun
> *Cc: *Saleem Abdulrasool , "
> cfe-commits@lists.llvm.org" , Aaron Ballman <
> aa...@aaronballman.com>
>
>
> *Subjec
mmits@lists.llvm.org"
, Aaron Ballman
Subject: Re: Add warning for c++ member variable shadowing
I think that the patch is starting to look pretty good!
Can you add some test cases for the particular cases to diagnose in a separate
test set to ensure that we have proper coverage of the various ca
, "
> cfe-commits@lists.llvm.org" , Aaron Ballman <
> aa...@aaronballman.com>
>
> *Subject: *Re: Add warning for c++ member variable shadowing
>
>
>
> +def warn_shadow_member_variable : Warning<
>
> + "shadowed variable '%0' in type '%
t;cfe-commits@lists.llvm.org"
, Aaron Ballman
Subject: Re: Add warning for c++ member variable shadowing
+def warn_shadow_member_variable : Warning<
+ "shadowed variable '%0' in type '%1' inheriting from type '%2'">,
The phrasing of this is incor
if we call A.bases()
> directly.
>
>
>
> Thanks
>
>
>
> James
>
>
>
>
>
> *From: *Saleem Abdulrasool
> *Date: *Tuesday, January 24, 2017 at 7:10 PM
> *To: *James Sun
> *Cc: *"cfe-commits@lists.llvm.org" , Aaron
> Ballman , Ric
if we call A.bases()
directly.
Thanks
James
From: Saleem Abdulrasool
Date: Tuesday, January 24, 2017 at 7:10 PM
To: James Sun
Cc: "cfe-commits@lists.llvm.org" , Aaron Ballman
, Richard Smith
Subject: Re: Add warning for c++ member variable shadowing
Some more stylistic
Some more stylistic comments:
The description that you have on CheckShadowInheritedVariables isn't really
the type of comments that we have in doxygen form. Im not sure if its in
line with the rest of the code.
The ignore warning comments are restating what is in the code, please
remove them.
C
Coding style change
From: James Sun
Date: Tuesday, January 24, 2017 at 2:36 PM
To: "cfe-commits@lists.llvm.org"
Subject: Add warning for c++ member variable shadowing
Dear members
Here is a patch (attached) to create warnings where a member variable shadows
the one in one of its inheriting cl
25 matches
Mail list logo
