RE: [PATCH] D48100: Append new attributes to the end of an AttributeList.

2018-08-03 Thread Keane, Erich via cfe-commits
fe-commits ; junb...@codeaurora.org; florian.h...@arm.com Subject: Re: [PATCH] D48100: Append new attributes to the end of an AttributeList. On Fri, Aug 3, 2018 at 10:09 AM, Keane, Erich wrote: >> As a possible idea (that may or may not work): the Attr object itself has a >> SourceR

Re: [PATCH] D48100: Append new attributes to the end of an AttributeList.

2018-08-03 Thread Aaron Ballman via cfe-commits
...@google.com; david.gr...@arm.com; llvm-commits > ; jrt...@jrtc27.com; Richard Smith > ; Keane, Erich ; Eric > Christopher ; zhaos...@codeaurora.org; Simon Atanasyan > ; cfe-commits ; > junb...@codeaurora.org; florian.h...@arm.com > Subject: Re: [PATCH] D48100: Append ne

RE: [PATCH] D48100: Append new attributes to the end of an AttributeList.

2018-08-03 Thread Keane, Erich via cfe-commits
deaurora.org; Simon Atanasyan ; cfe-commits ; junb...@codeaurora.org; florian.h...@arm.com Subject: Re: [PATCH] D48100: Append new attributes to the end of an AttributeList. On Fri, Aug 3, 2018 at 8:53 AM, Erich Keane via Phabricator wrote: > erichkeane added a comment. > > In https://re

Re: [PATCH] D48100: Append new attributes to the end of an AttributeList.

2018-08-03 Thread Aaron Ballman via cfe-commits
On Fri, Aug 3, 2018 at 8:53 AM, Erich Keane via Phabricator wrote: > erichkeane added a comment. > > In https://reviews.llvm.org/D48100#1186654, @Meinersbur wrote: > >> I have two approaches to tackle the wrong marker order: >> https://reviews.llvm.org/D50215 and https://reviews.llvm.org/D50216.