> As a possible idea (that may or may not work): the Attr object itself has a > SourceRange on it; perhaps a solution is to keep the > attributes in sorted > order within DeclBase::addAttr() based on the SourceRanges passed in?
Interestingly, I think I came up with that idea in a comment on D50214. I think that we should either keep the attributes sorted, or make the iterator give a sorted version. -----Original Message----- From: Aaron Ballman [mailto:[email protected]] Sent: Friday, August 3, 2018 7:02 AM To: [email protected] Cc: Michael Kruse <[email protected]>; Hal Finkel <[email protected]>; Tyler Nowicki <[email protected]>; Alexey Bataev <[email protected]>; John McCall <[email protected]>; George Burgess IV <[email protected]>; Nick Lewycky <[email protected]>; Nick Lewycky <[email protected]>; [email protected]; [email protected]; [email protected]; llvm-commits <[email protected]>; [email protected]; Richard Smith <[email protected]>; Keane, Erich <[email protected]>; Eric Christopher <[email protected]>; [email protected]; Simon Atanasyan <[email protected]>; cfe-commits <[email protected]>; [email protected]; [email protected] Subject: Re: [PATCH] D48100: Append new attributes to the end of an AttributeList. On Fri, Aug 3, 2018 at 8:53 AM, Erich Keane via Phabricator <[email protected]> wrote: > erichkeane added a comment. > > In https://reviews.llvm.org/D48100#1186654, @Meinersbur wrote: > >> I have two approaches to tackle the wrong marker order: >> https://reviews.llvm.org/D50215 and https://reviews.llvm.org/D50216. IMHO >> both are too invasive to be justified for the small issue. > > > I think you're right here. I despise https://reviews.llvm.org/D50215, and > only mostly hate https://reviews.llvm.org/D50216. I think I'd prefer leaving > this as a "FIXME" somewhere. Oye, I'm in agreement that this should be fixed but that neither of these approaches leaves me feeling warm and fuzzy. As a possible idea (that may or may not work): the Attr object itself has a SourceRange on it; perhaps a solution is to keep the attributes in sorted order within DeclBase::addAttr() based on the SourceRanges passed in? ~Aaron > > > Repository: > rL LLVM > > https://reviews.llvm.org/D48100 > > > _______________________________________________ cfe-commits mailing list [email protected] http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
