Re: [PATCH] D25008: [libcxx] Include unwinder library in the linker script

2016-09-28 Thread Michał Górny via cfe-commits
mgorny added a comment. In https://reviews.llvm.org/D25008#555041, @rmaprath wrote: > The patch generally makes sense to me. > > I wonder if the test configuration can also benefit from this; > `test/libcxx/test/target_info.py` manually updates the link line to use > `-lgcc_s` or `-lunwind` dep

Re: [PATCH] D25008: [libcxx] Include unwinder library in the linker script

2016-09-28 Thread Asiri Rathnayake via cfe-commits
rmaprath added a subscriber: rmaprath. rmaprath added a comment. The patch generally makes sense to me. I wonder if the test configuration can also benefit from this; `test/libcxx/test/target_info.py` manually updates the link line to use `-lgcc_s` or `-lunwind` depending on how the build is co