This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL280236: [clang-tidy docs] Add missing option docs. (authored
by hokein).
Changed prior to commit:
https://reviews.llvm.org/D23918?vs=69839&id=69840#toc
Reposito
hokein updated this revision to Diff 69839.
hokein added a comment.
Update HeaderFileExtensions doc for all documents.
https://reviews.llvm.org/D23918
Files:
docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst
docs/clang-tidy/checks/google-build-namespaces.rst
doc
hokein updated this revision to Diff 69838.
hokein marked 3 inline comments as done.
hokein added a comment.
Fix more comments.
https://reviews.llvm.org/D23918
Files:
docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst
docs/clang-tidy/checks/google-build-namespaces.
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for the updated documentation!
https://reviews.llvm.org/D23918
___
cfe-commits mailing list
cfe-commits@lists.llvm.
hokein marked an inline comment as done.
Comment at: docs/clang-tidy/checks/google-build-namespaces.rst:21
@@ +20,3 @@
+ extensions should not include "." prefix). Default is "h,hh,hpp,hxx".
+ For header files without an extension, use an empty string (if there are no
+ othe
aaron.ballman added inline comments.
Comment at: docs/clang-tidy/checks/google-build-namespaces.rst:21
@@ +20,3 @@
+ extensions should not include "." prefix). Default is "h,hh,hpp,hxx".
+ For header files without an extension, use an empty string (if there are no
+ other de
hokein added inline comments.
Comment at: docs/clang-tidy/checks/google-build-namespaces.rst:21
@@ +20,3 @@
+ extensions should not include "." prefix). Default is "h,hh,hpp,hxx".
+ For header files without an extension, use an empty string (if there are no
+ other desired e
aaron.ballman added inline comments.
Comment at: docs/clang-tidy/checks/google-build-namespaces.rst:21
@@ +20,3 @@
+ extensions should not include "." prefix). Default is "h,hh,hpp,hxx".
+ For header files without an extension, use an empty string (if there are no
+ other de
hokein added a comment.
wow, thanks for many detailed comments.
Comment at: docs/clang-tidy/checks/google-build-namespaces.rst:21
@@ +20,3 @@
+ extensions should not contain "." prefix). "h,hh,hpp,hxx" by default. For
+ extension-less header files, using an empty string or l
hokein updated this revision to Diff 69812.
hokein marked 26 inline comments as done.
hokein added a comment.
Address aaron's comments.
https://reviews.llvm.org/D23918
Files:
docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst
docs/clang-tidy/checks/google-build-nam
aaron.ballman requested changes to this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision now requires changes to proceed.
Thank you for working on this!
Comment at:
docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant
Eugene.Zelenko added a subscriber: aaron.ballman.
Eugene.Zelenko added a comment.
I don't have further comments, but as non-English speaker and mediocre writer,
I would like see other people comments. May be @aaron.ballman could help if
Alexander is busy?
https://reviews.llvm.org/D23918
___
hokein updated this revision to Diff 69679.
hokein marked an inline comment as done.
hokein added a comment.
- Use empty string words.
- rebase to master.
https://reviews.llvm.org/D23918
Files:
docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst
docs/clang-tidy/chec
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/google-runtime-int.rst:27
@@ +26,2 @@
+
+ A string represents type suffix. Default is empty.
I think empty string will be better. Same for other occurrences.
https://reviews.llvm.org/D239
hokein added inline comments.
Comment at: docs/clang-tidy/checks/google-readability-namespace-comments.rst:11
@@ +10,3 @@
+
+Options
+---
Eugene.Zelenko wrote:
> This documentation is redirect, so options description should be moved to
> llvm-namespace-commen
hokein updated this revision to Diff 69539.
hokein added a comment.
Remove extra blank line.
https://reviews.llvm.org/D23918
Files:
docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst
docs/clang-tidy/checks/google-build-namespaces.rst
docs/clang-tidy/checks/google
hokein updated this revision to Diff 69538.
hokein marked 8 inline comments as done.
hokein added a comment.
Address review comments:
- Use "Default is XYZ" instead of "XYZ by default".
- Replace empty string `` with empty word, passing docs compilation.
https://reviews.llvm.org/D23918
Files:
Eugene.Zelenko added a comment.
General comments:
- I think //default is XYZ// is better then //XYZ by default//.
- There are discrepancies: option represent//ing// and option represent//s//.
I think will be good idea to involve native English speaker in review.
Comment at: d
18 matches
Mail list logo
