hokein added a comment. wow, thanks for many detailed comments.
================ Comment at: docs/clang-tidy/checks/google-build-namespaces.rst:21 @@ +20,3 @@ + extensions should not contain "." prefix). "h,hh,hpp,hxx" by default. For + extension-less header files, using an empty string or leaving an empty string + between "," if there are other filename extensions. ---------------- aaron.ballman wrote: > How about: > ``` > For header files without an extension, use an empty string (if there are no > other desired extensions) or leave an empty element in the list. e.g., > "h,hh,hpp,hxx," (note the trailing comma). > ``` > (assuming my example actually works.) The trailing comma in `h,hh,hpp,hxx,` is not required here. ================ Comment at: docs/clang-tidy/checks/misc-suspicious-missing-comma.rst:53 @@ +52,3 @@ + + A string represents maximal threshold ratio of suspicious string literals to + be considered. Default is `.2`. ---------------- aaron.ballman wrote: > represents->specifying > maximal->maximum > > Should actually state that the string represents a floating-point value > between 0 and 1 (inclusive? exclusive?). Also, is it really a string? aka, > does it need quotes, or is it okay to not use quotes (as the default > suggests)? Yeah, this is a string in the check's implementation. https://reviews.llvm.org/D23918 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
