aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
https://reviews.llvm.org/D22668
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
hubert.reinterpretcast updated this revision to Diff 66194.
hubert.reinterpretcast added a comment.
Make FixedSizeStorage accessible to test code
FixedSizeStorage and not FixedSizeStorageOwner is what the test code needs. Use
alias template to avoid issues with MSVC.
https://reviews.llvm.org/D
hubert.reinterpretcast updated this revision to Diff 66190.
hubert.reinterpretcast added a comment.
Make FixedSizeStorageOwner accessible to test code
https://reviews.llvm.org/D22668
Files:
include/llvm/Support/AlignOf.h
include/llvm/Support/MathExtras.h
include/llvm/Support/TrailingObjec
hubert.reinterpretcast updated this revision to Diff 66186.
hubert.reinterpretcast added a comment.
Replace call to LLVM_CONSTEXPR function in constant expression context
https://reviews.llvm.org/D22668
Files:
include/llvm/Support/AlignOf.h
include/llvm/Support/MathExtras.h
include/llvm/S
hubert.reinterpretcast updated this revision to Diff 66185.
hubert.reinterpretcast marked an inline comment as done.
hubert.reinterpretcast added a comment.
Avoid MSVC C4099: replace 'struct' with 'class'
https://reviews.llvm.org/D22668
Files:
include/llvm/Support/AlignOf.h
include/llvm/Sup
hubert.reinterpretcast updated this revision to Diff 66179.
hubert.reinterpretcast added a comment.
Address review comments: add tests, access control, Doxygen
https://reviews.llvm.org/D22668
Files:
include/llvm/Support/AlignOf.h
include/llvm/Support/MathExtras.h
include/llvm/Support/Trai
aaron.ballman added a comment.
In https://reviews.llvm.org/D22668#500340, @hubert.reinterpretcast wrote:
> In https://reviews.llvm.org/D22668#499164, @aaron.ballman wrote:
>
> > I don't suppose there's a way to test these changes, is there?
>
>
> It's a utility class (which is not even used yet).
hubert.reinterpretcast added a comment.
In https://reviews.llvm.org/D22668#499164, @aaron.ballman wrote:
> I don't suppose there's a way to test these changes, is there?
It's a utility class (which is not even used yet). I am not aware of testing
for the ADTs, etc. aside from using them intern
aaron.ballman added a comment.
I don't suppose there's a way to test these changes, is there?
Comment at: include/llvm/Support/MathExtras.h:682
@@ +681,3 @@
+
+// alignTo for contexts where a constant expression is required.
+// FIXME: remove when LLVM_CONSTEXPR becomes really c
