hubert.reinterpretcast added a comment.
In https://reviews.llvm.org/D22668#499164, @aaron.ballman wrote:
> I don't suppose there's a way to test these changes, is there?
It's a utility class (which is not even used yet). I am not aware of testing
for the ADTs, etc. aside from using them internally. Perhaps I should mark the
change as NFC?
================
Comment at: include/llvm/Support/MathExtras.h:682
@@ +681,3 @@
+
+// alignTo for contexts where a constant expression is required.
+// FIXME: remove when LLVM_CONSTEXPR becomes really constexpr
----------------
aaron.ballman wrote:
> Switch to use doxygen-style comments?
Okay. I'll need to evaluate the appearance of the FIXME in Doxygen.
================
Comment at: include/llvm/Support/TrailingObjects.h:149
@@ -148,1 +148,3 @@
+ struct RequiresRealignment {
+ static const bool value =
----------------
aaron.ballman wrote:
> Does this need to be public?
This is in an "Impl" class in an "internal" namespace, so I believe leaving it
public is reasonable.
https://reviews.llvm.org/D22668
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
