Re: [PATCH] D17380: [libcxx] Split locale management out of ibm/xlocale.h. NFCI

2016-02-19 Thread Craig, Ben via cfe-commits
On 2/19/2016 8:36 AM, Joerg Sonnenberger via cfe-commits wrote: On Thu, Feb 18, 2016 at 03:39:29PM +, Ben Craig via cfe-commits wrote: Unfortunately, I have no access to an AIX machine to build with, so this change has been made blind. Any reason why this is not using "new" and "delete"? I

Re: [PATCH] D17380: [libcxx] Split locale management out of ibm/xlocale.h. NFCI

2016-02-19 Thread Joerg Sonnenberger via cfe-commits
On Thu, Feb 18, 2016 at 03:39:29PM +, Ben Craig via cfe-commits wrote: > Unfortunately, I have no access to an AIX machine to build with, so > this change has been made blind. Any reason why this is not using "new" and "delete"? I think I would prefer to not define uselocale, but that can be l

Re: [PATCH] D17380: [libcxx] Split locale management out of ibm/xlocale.h. NFCI

2016-02-18 Thread Jonathan Roelofs via cfe-commits
jroelofs added a subscriber: jroelofs. jroelofs accepted this revision. jroelofs added a reviewer: jroelofs. jroelofs added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D17380 ___ cfe-commits mailing list