r294676
On Thu, Feb 9, 2017 at 4:05 PM David L. Jones via Phabricator <
revi...@reviews.llvm.org> wrote:
> dlj added inline comments.
>
>
>
> Comment at: cfe/trunk/lib/CodeGen/MacroPPCallbacks.cpp:125
> + switch (Status) {
> + default:
> +llvm_unreachable("Do not expect to
> On Feb 8, 2017, at 2:31 PM, David Blaikie wrote:
>
>
>
> On Wed, Feb 8, 2017 at 2:25 PM Amjad Aboud via Phabricator
> mailto:revi...@reviews.llvm.org>> wrote:
> aaboud added a comment.
>
> > How much does the build directory grow?
> > Is there any noticeable compile time regression?
>
>
On Wed, Feb 8, 2017 at 2:25 PM Amjad Aboud via Phabricator <
revi...@reviews.llvm.org> wrote:
> aaboud added a comment.
>
> > How much does the build directory grow?
> > Is there any noticeable compile time regression?
>
> I build clang in release mode using GCC, then used that build to build
> c
On Tue, Feb 7, 2017 at 11:01 AM Amjad Aboud via Phabricator <
revi...@reviews.llvm.org> wrote:
> aaboud added a comment.
>
> In https://reviews.llvm.org/D16135#669416, @aprantl wrote:
>
> > In https://reviews.llvm.org/D16135#669045, @aaboud wrote:
> >
> > > Addressed Adrian last comments.
> > > A
aaboud added reviewers: erichkeane, bwyma.
aaboud updated this revision to Diff 65551.
aaboud added a comment.
Updated patch to top of trunk (r276746) - Thanks to Ranjeet Singh.
Please, provide your feedback.
https://reviews.llvm.org/D16135
Files:
include/clang/AST/ASTConsumer.h
lib/AST/AS
; From: Ranjeet Singh [mailto:ranjeet.si...@arm.com]
> Sent: Friday, July 22, 2016 20:16
> To: Aboud, Amjad ; rich...@metafoo.co.uk;
> paul.robin...@sony.com; apra...@apple.com
> Cc: ranjeet.si...@arm.com; cfe-commits@lists.llvm.org
> Subject: Re: [PATCH] D16135: Macro Debug Info sup
rs added a subscriber: rs.
rs added a comment.
Hi Amjad,
are you still planning on getting this patch and
https://reviews.llvm.org/D16077 committed ? It looks like these two patches are
final pieces in the puzzle to get macro information in the DWARF debug output.
I've downloaded the diffs and
aaboud updated this revision to Diff 47997.
aaboud marked an inline comment as done.
aaboud added a comment.
Applied Adrian comment.
http://reviews.llvm.org/D16135
Files:
include/clang/AST/ASTConsumer.h
lib/AST/ASTConsumer.cpp
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
lib/
aprantl added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:2099
@@ -2098,1 +2098,3 @@
+llvm::DIMacro *CGDebugInfo::CreateMacro(llvm::DIMacroFile *Parent, bool
IsUndef,
+SourceLocation LineLoc, StringRef Name,
aaboud updated this revision to Diff 46034.
aaboud marked 6 inline comments as done.
aaboud added a comment.
Added comments explaining the implementation.
http://reviews.llvm.org/D16135
Files:
include/clang/AST/ASTConsumer.h
lib/AST/ASTConsumer.cpp
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGe
aprantl added a comment.
Added a few stylistic comments and request for more documentation.
Comment at: lib/CodeGen/MacroPPCallbacks.cpp:1
@@ +1,2 @@
+//===--- MacroPPCallbacks.h ---*- C++
-*-===//
+//
Please run your patch t
aaboud added inline comments.
Comment at: include/clang/AST/ASTConsumer.h:163
@@ -155,1 +162,3 @@
+ /// The caller takes ownership on the returned pointer.
+ virtual std::unique_ptr
CreatePreprocessorCallbacks(Preprocessor &PP);
};
Richard,
I know that you sug
12 matches
Mail list logo
