aaboud added inline comments. ================ Comment at: include/clang/AST/ASTConsumer.h:163 @@ -155,1 +162,3 @@ + /// The caller takes ownership on the returned pointer. + virtual std::unique_ptr<PPCallbacks> CreatePreprocessorCallbacks(Preprocessor &PP); }; ---------------- Richard, I know that you suggested not to introduce the Preprocessor in anyway to the ASTConsumer. However, as I could not understand the other way to support macros in Clang without applying a huge redesign, I decided to upload the code I suggested in the proposal. http://lists.llvm.org/pipermail/llvm-dev/2015-November/092449.html
If you still think that this approach is not the right one, I would appreciate it if you can explain again how to implement the macro support differently. http://reviews.llvm.org/D16135 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
