This revision was automatically updated to reflect the committed changes.
Closed by commit rL254927: [ThinLTO] Option to invoke ThinLTO backend passes
and importing (authored by tejohnson).
Changed prior to commit:
http://reviews.llvm.org/D15025?vs=42069&id=42084#toc
Repository:
rL LLVM
htt
joker.eph accepted this revision.
joker.eph added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
http://reviews.llvm.org/D15025
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
tejohnson updated this revision to Diff 42069.
tejohnson added a comment.
- Rename -fthinlto-backend to -fthinlto-index as per review and IRC.
http://reviews.llvm.org/D15025
Files:
include/clang/CodeGen/BackendUtil.h
include/clang/Driver/Options.td
include/clang/Driver/Types.h
include/c
tejohnson updated this revision to Diff 41935.
tejohnson added a comment.
- Move ownership of FunctionInfoIndex onto EmitAssemblyHelper
http://reviews.llvm.org/D15025
Files:
include/clang/CodeGen/BackendUtil.h
include/clang/Driver/Options.td
include/clang/Driver/Types.h
include/clang/Fr
tejohnson updated this revision to Diff 41926.
tejohnson added a comment.
- Use new renameModuleForThinLTO helper function from llvm.
- Fix tests
I have not change the option name yet. Wanted to be sure we have a name that
reflects the fact that this is a special compile that changes the compi
> On Dec 4, 2015, at 9:14 AM, Teresa Johnson wrote:
>
> tejohnson added inline comments.
>
>
> Comment at: lib/CodeGen/CodeGenAction.cpp:822
> @@ +821,3 @@
> + TheModule = std::move(Combined);
> +}
> +
>
> joker.eph wrote:
>> tejohnson wrote:
>>> joker
tejohnson added inline comments.
Comment at: lib/CodeGen/CodeGenAction.cpp:822
@@ +821,3 @@
+ TheModule = std::move(Combined);
+}
+
joker.eph wrote:
> tejohnson wrote:
> > joker.eph wrote:
> > > tejohnson wrote:
> > > > joker.eph wrote:
> > > > > Could we
joker.eph added inline comments.
Comment at: lib/CodeGen/CodeGenAction.cpp:822
@@ +821,3 @@
+ TheModule = std::move(Combined);
+}
+
tejohnson wrote:
> joker.eph wrote:
> > tejohnson wrote:
> > > joker.eph wrote:
> > > > Could we refactor this in a helper
tejohnson added inline comments.
Comment at: lib/CodeGen/CodeGenAction.cpp:822
@@ +821,3 @@
+ TheModule = std::move(Combined);
+}
+
joker.eph wrote:
> tejohnson wrote:
> > joker.eph wrote:
> > > Could we refactor this in a helper in llvm?
> > I can create
joker.eph added inline comments.
Comment at: lib/CodeGen/CodeGenAction.cpp:822
@@ +821,3 @@
+ TheModule = std::move(Combined);
+}
+
tejohnson wrote:
> joker.eph wrote:
> > Could we refactor this in a helper in llvm?
> I can create a new Linker interface t
tejohnson added a comment.
> Talked with Duncan, we're not convinced about -fthinlto-backend=... for the
> option name: the word backend does not seems right here. What about
> -fthinlto-index=...?
I wanted to express that this was invoking a different pipeline, and
distinguish from a normal
joker.eph added a comment.
Talked with Duncan, we're not convinced about //-fthinlto-backend=...// for the
option name: the word //backend// does not seems right here. What about
//-fthinlto-index=...//?
Comment at: lib/CodeGen/CodeGenAction.cpp:822
@@ +821,3 @@
+ TheModu
joker.eph added a comment.
Looks good to me but I'd like another opinion on the name of
"-fthinlto-backend", Duncan?
Comment at: include/clang/Driver/Types.h:68
@@ -66,1 +67,3 @@
+ bool isLLVMIR(ID Id);
+
/// isCuda - Is this a CUDA input.
I guess you could
tejohnson updated this revision to Diff 41787.
tejohnson added a comment.
- Address more comments.
http://reviews.llvm.org/D15025
Files:
include/clang/CodeGen/BackendUtil.h
include/clang/Driver/Options.td
include/clang/Driver/Types.h
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen
tejohnson marked 4 inline comments as done.
tejohnson added a comment.
New patch coming I think addresses all your comments.
Thanks, Teresa
Comment at: lib/CodeGen/BackendUtil.cpp:290
@@ +289,3 @@
+ // setup for LTO compiles invoked via the gold plugin and the llvm-lto tool.
+
joker.eph added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:290
@@ +289,3 @@
+ // setup for LTO compiles invoked via the gold plugin and the llvm-lto tool.
+ if (!CodeGenOpts.ThinLTOIndexFile.empty() && !CodeGenOpts.DisableLLVMOpts) {
+legacy::PassManager *MPM =
tejohnson updated this revision to Diff 41542.
tejohnson added a comment.
- Address Mehdi's comments.
http://reviews.llvm.org/D15025
Files:
include/clang/CodeGen/CodeGenAction.h
include/clang/Driver/Options.td
include/clang/Driver/Types.h
include/clang/Frontend/CodeGenOptions.h
lib/Co
tejohnson marked an inline comment as done.
tejohnson added a comment.
Updated patch coming shortly.
Comment at: lib/CodeGen/BackendUtil.cpp:308
@@ +307,3 @@
+return;
+ }
+
joker.eph wrote:
> It does not seem to be nicely integrated within the context of th
tejohnson added a comment.
Thanks for the review, comments below.
Teresa
Comment at: lib/CodeGen/CodeGenAction.cpp:190
@@ -169,3 +189,3 @@
[=](const DiagnosticInfo &DI) {
- linkerDiagnosticHandler(DI, LinkModule);
joker.eph added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:308
@@ +307,3 @@
+return;
+ }
+
It does not seem to be nicely integrated within the context of this function.
What about all the options set just a few line below? It is not clear if
`
20 matches
Mail list logo
