tejohnson marked an inline comment as done. tejohnson added a comment. Updated patch coming shortly.
================ Comment at: lib/CodeGen/BackendUtil.cpp:308 @@ +307,3 @@ + return; + } + ---------------- joker.eph wrote: > It does not seem to be nicely integrated within the context of this function. > What about all the options set just a few line below? It is not clear if > `CodeGenOpts.DisableLLVMOpts` is well honored either. This is basically the same LTO pipeline we setup in both gold-plugin.cpp and in LTOCodeGenerator::optimize (used by the llvm-lto tool and presumably ld64). I added that info to the comments. It is a special pipeline for this mode. That being said, I have made a couple of changes in my latest version to be uploaded shortly: Skip this special pipeline if DisableLLVMOpts is true; set LoopVectorize to CodeGenOpts.VectorizeLoop as in the below code; set SLPVectorize to CodeGenOpts.VectorizeSLP as in the below code. One thing I may do first actually is to refactor this code out of gold-plugin and LTOCodeGenerator into a PassManagerBuilder helper function. http://reviews.llvm.org/D15025 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
