bcraig abandoned this revision.
bcraig added a comment.
Largely supplanted by r253958
http://reviews.llvm.org/D14506
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Looks good to me. I'm not too worried about the compactness of the
visitor class.
On 11/16/2015 7:10 PM, Richard Smith wrote:
Attached patch makes RAV fully data-recursive when visiting
statements, except in cases where the derived class could tell the
difference (when it falls back to a norm
On Tue, Nov 17, 2015 at 10:14 AM Richard Smith
wrote:
> LOn Nov 17, 2015 12:49 AM, "Manuel Klimek" wrote:
> > Richard, this is still optional, right? (the AST matchers need to
> control visitation)
>
> This doesn't change RAV semantics at all (or if it does, it's a bug). If
> any of the extensio
LOn Nov 17, 2015 12:49 AM, "Manuel Klimek" wrote:
> Richard, this is still optional, right? (the AST matchers need to control
visitation)
This doesn't change RAV semantics at all (or if it does, it's a bug). If
any of the extension points are overridden in the derived class, data
recursion is aut
Richard, this is still optional, right? (the AST matchers need to control
visitation)
On Tue, Nov 17, 2015 at 2:26 AM Argyrios Kyrtzidis via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> W00t! That’s awesome Richard!
>
> On Nov 16, 2015, at 5:10 PM, Richard Smith wrote:
>
> Attached patch m
W00t! That’s awesome Richard!
> On Nov 16, 2015, at 5:10 PM, Richard Smith wrote:
>
> Attached patch makes RAV fully data-recursive when visiting statements,
> except in cases where the derived class could tell the difference (when it
> falls back to a normal recursive walk). The queue represe
I'm fine with this approach. How about I leave the file in place, but
replace the contents with a "using DataRecursiveASTVisitor =
RecursiveASTVisitor;" and see what breaks? That way I won't need to go
through a large retrofit.
On 11/16/2015 3:28 PM, Richard Smith wrote:
Rather than trying t
Rather than trying to maintain the horrible duplication between
DataRecursiveASTVisitor and RecursiveASTVisitor, can we just delete
DataRecursiveASTVisitor? RecursiveASTVisitor is data-recursive too these
days (and has a smarter implementation than DataRecursiveASTVisitor's from
what I can see), bu
LGTM.
> On Nov 16, 2015, at 12:32 PM, Ben Craig wrote:
>
> bcraig added a comment.
>
> Ping. Note that the test is basically a copy / paste job, and the new code
> in DataRecursiveASTVisitor.h is a very direct translation from the 'regular'
> RecursiveASTVisitor.h.
>
>
> http://reviews.llv
bcraig added a comment.
Ping. Note that the test is basically a copy / paste job, and the new code in
DataRecursiveASTVisitor.h is a very direct translation from the 'regular'
RecursiveASTVisitor.h.
http://reviews.llvm.org/D14506
___
cfe-commits
zaks.anna added a subscriber: zaks.anna.
zaks.anna added a comment.
Removed myself as a reviewer and added Argyrios instead.
http://reviews.llvm.org/D14506
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
11 matches
Mail list logo
