Prazek marked an inline comment as done.
Prazek added a comment.
http://reviews.llvm.org/D12385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek updated this revision to Diff 33273.
Prazek marked an inline comment as done.
http://reviews.llvm.org/D12385
Files:
lib/CodeGen/CGCXXABI.h
lib/CodeGen/CGClass.cpp
lib/CodeGen/CGVTables.cpp
lib/CodeGen/ItaniumCXXABI.cpp
lib/CodeGen/MicrosoftCXXABI.cpp
test/CodeGenCXX/template-in
Prazek marked 2 inline comments as done.
Comment at: lib/CodeGen/CGClass.cpp:1861
@@ +1860,3 @@
+ // We also have to make sure if we can refer to vtable:
+ // - If vtable is external then it's safe to use it (for availabe_externally
+ // CGVTables will make sure if it can emi
Prazek added a comment.
I will wait with pushing for tomorrow noon, in case someone want's to check the
code.
http://reviews.llvm.org/D12385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM with some comment tweaks.
Comment at: lib/CodeGen/CGClass.cpp:1861
@@ +1860,3 @@
+ // We also have to make sure if we can refer to vtable:
+ // - If vtable is external
Prazek updated this revision to Diff 33269.
http://reviews.llvm.org/D12385
Files:
lib/CodeGen/CGCXXABI.h
lib/CodeGen/CGClass.cpp
lib/CodeGen/CGVTables.cpp
lib/CodeGen/ItaniumCXXABI.cpp
lib/CodeGen/MicrosoftCXXABI.cpp
test/CodeGenCXX/template-instantiation.cpp
test/CodeGenCXX/thunks.
Prazek marked 3 inline comments as done.
Prazek added a comment.
http://reviews.llvm.org/D12385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added inline comments.
Comment at: lib/CodeGen/CGCXXABI.h:221
@@ -220,4 +220,3 @@
- virtual bool canEmitAvailableExternallyVTable(
- const CXXRecordDecl *RD) const = 0;
+ virtual bool canEmitUnusedVTable(const CXXRecordDecl *RD) const = 0;
This w
