Re: [PATCH] D11761: [PATCH] clang-query quit command

2015-08-06 Thread Aaron Ballman via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. In http://reviews.llvm.org/D11761#218178, @pcc wrote: > You'd have had to look at the documentation (i.e. the "help" message) anyway > to determine the right way to terminate the program. We can document > Ctrl-{D,Z} there inste

Re: [PATCH] D11761: [PATCH] clang-query quit command

2015-08-05 Thread Manuel Klimek
klimek added a comment. Peter, any particular reason? In http://reviews.llvm.org/D11761#218151, @aaron.ballman wrote: > In http://reviews.llvm.org/D11761#218141, @pcc wrote: > > > I normally quit clang-query, or pretty much any other interactive command > > line program, by typing end-of-file (

Re: [PATCH] D11761: [PATCH] clang-query quit command

2015-08-05 Thread Aaron Ballman
aaron.ballman added a comment. In http://reviews.llvm.org/D11761#218141, @pcc wrote: > I normally quit clang-query, or pretty much any other interactive command > line program, by typing end-of-file (Ctrl-D on Unix, Ctrl-Z on > Windows). If this works on Windows 10 I'd rather users do it that

Re: [PATCH] D11761: [PATCH] clang-query quit command

2015-08-05 Thread Peter Collingbourne
pcc added a comment. I normally quit clang-query, or pretty much any other interactive command line program, by typing end-of-file (Ctrl-D on Unix, Ctrl-Z on Windows). If this works on Windows 10 I'd rather users do it that way. We can make this more discoverable through documentation. http:

Re: [PATCH] D11761: [PATCH] clang-query quit command

2015-08-05 Thread Manuel Klimek
klimek added a comment. For what it's worth, I think this looks good, mainly curious whether pcc has any remarks code-wise. http://reviews.llvm.org/D11761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

Re: [PATCH] D11761: [PATCH] clang-query quit command

2015-08-05 Thread Manuel Klimek
klimek added a reviewer: pcc. klimek added a comment. +pcc for the opinion of the creator :) http://reviews.llvm.org/D11761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits