aaron.ballman closed this revision.
aaron.ballman added a comment.
In http://reviews.llvm.org/D11761#218178, @pcc wrote:
> You'd have had to look at the documentation (i.e. the "help" message) anyway
> to determine the right way to terminate the program. We can document
> Ctrl-{D,Z} there instead of introducing a new command.
FWIW (and I should probably be ashamed to admit this in public), but when I
first ran clang-query in interactive mode, I tried "quit", then I tried "exit",
and then I just went and End Tasked the application. Control codes didn't enter
my thought process, and I didn't try "help" for another few sessions.
Discoverability isn't just about reading documentation, it's about ecosystem
"norms" too.
> But this isn't worth arguing about and I am clearly in the minority here, if
> you still think that adding a new command here is the way to go, LGTM.
Thank you, I've commit in r244206
~Aaron
http://reviews.llvm.org/D11761
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
