[clang] disable unary, vector mask (PR #130400)

2025-03-17 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: https://sourcegraph.com/search?q=context:global+__builtin_shufflevector%5C%28%5BA-Za-z0-9_%5D%2B%2C.%5BA-Za-z0-9_%5D%2B%5C%29+-file:.*test.*&patternType=regexp&case=yes&sm=0 doesn't show use in the wild, but perhaps someone can devise a better search string. In the meantime,

[clang] disable unary, vector mask (PR #130400)

2025-03-17 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: The current behavior seems to be intentional, at least it was added as part of 1fa36050abd8b798927829f0b0a4362f9e9c63eb which was solving https://github.com/llvm/llvm-project/issues/12837. CC @efriedma-quic https://github.com/llvm/llvm-project/pull/130400 _

[clang] disable unary, vector mask (PR #130400)

2025-03-17 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: I have no idea how much the two-argument version of __builtin_shufflevector is used in practice. I wouldn't want to remove it without a better idea of that... I vaguely recall it might be relevant for some GPU languages. It should be possible to fix the crash by just reje

[clang] disable unary, vector mask (PR #130400)

2025-03-15 Thread Timm Baeder via cfe-commits
tbaederr wrote: It sounds a little weird to allow the vector+int version only in codegen and not in constant evaluation. If we reject it, we should do that in Sema I think. git blame for `Sema::BuiltinShuffleVector` is all over the place, so pinging @AaronBallman @cor3ntin to see if this goes

[clang] disable unary, vector mask (PR #130400)

2025-03-11 Thread via cfe-commits
wsehjk wrote: In the `builtinshufflevetor2.c` test ```c++ // CHECK-LABEL: define {{.*}}void @clang_shufflevector_v_v( void clang_shufflevector_v_v( float4* A, float4 x, uint4 mask ) { // CHECK: [[MASK:%.*]] = and <4 x i32> {{%.*}}, splat (i32 3) // CHECK: [[I:%.*]] = extractelement <4 x i32> [[MA

[clang] disable unary, vector mask (PR #130400)

2025-03-11 Thread via cfe-commits
wsehjk wrote: > You can see two test failures in the CI output above. Hi. This PR disables the unary version of` __builtin_shufflevector(vec, mask)`. If my implementation is correct, I believe we should remove the unary version test to pass the CI. https://github.com/llvm/llvm-project/pull/13

[clang] disable unary, vector mask (PR #130400)

2025-03-10 Thread Timm Baeder via cfe-commits
tbaederr wrote: You can see two test failures in the CI output above. https://github.com/llvm/llvm-project/pull/130400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] disable unary, vector mask (PR #130400)

2025-03-08 Thread via cfe-commits
https://github.com/wsehjk updated https://github.com/llvm/llvm-project/pull/130400 >From 2bae9c70106ffb96dc237ee539dd7e3438025b01 Mon Sep 17 00:00:00 2001 From: wang shiwen Date: Sat, 8 Mar 2025 15:40:22 +0800 Subject: [PATCH] disable unary, vector mask --- clang/lib/Sema/SemaChecking.cpp

[clang] disable unary, vector mask (PR #130400)

2025-03-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Leslie (wsehjk) Changes This pr is to fix #92342. --- Full diff: https://github.com/llvm/llvm-project/pull/130400.diff 2 Files Affected: - (modified) clang/lib/Sema/SemaChecking.cpp (+6-18) - (modified) clang/test/Sema/constant_builti

[clang] disable unary, vector mask (PR #130400)

2025-03-07 Thread via cfe-commits
wsehjk wrote: @tbaederr Could you review my code? I'm not sure if I did it right https://github.com/llvm/llvm-project/pull/130400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] disable unary, vector mask (PR #130400)

2025-03-07 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] disable unary, vector mask (PR #130400)

2025-03-07 Thread via cfe-commits
https://github.com/wsehjk created https://github.com/llvm/llvm-project/pull/130400 This pr is to fix #92342. >From a6ca9cc820e98b093215b1bd0787d4fa3d31742d Mon Sep 17 00:00:00 2001 From: wang shiwen Date: Sat, 8 Mar 2025 15:40:22 +0800 Subject: [PATCH] disable unary, vector mask --- clang/l