[clang] cuda clang: Add support for CUDA surfaces (PR #132883)

2025-04-09 Thread Artem Belevich via cfe-commits
Artem-B wrote: @AustinSchuh One thing I've missed during review is that the test clang/test/CodeGen/nvptx-surface.cu should probably go into clang/test/CodeGenCUDA This would also obviate the need for #134459. Can you send the patch to move the test to the right location? https://github.com

[clang] cuda clang: Add support for CUDA surfaces (PR #132883)

2025-04-05 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B closed https://github.com/llvm/llvm-project/pull/132883 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cuda clang: Add support for CUDA surfaces (PR #132883)

2025-04-05 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux` running on `sanitizer-buildbot7` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/51/builds/13779 Here is the relevant piece of the

[clang] cuda clang: Add support for CUDA surfaces (PR #132883)

2025-04-05 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B approved this pull request. Nice. Now we're missing the two last steps; - that ptxas accepts the inline asm instructions we generate - that those instructions actually do what they are intended to do. Can you manually verify that the test file actually compiles to a G

[clang] cuda clang: Add support for CUDA surfaces (PR #132883)

2025-04-05 Thread Austin Schuh via cfe-commits
https://github.com/AustinSchuh edited https://github.com/llvm/llvm-project/pull/132883 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cuda clang: Add support for CUDA surfaces (PR #132883)

2025-04-05 Thread Austin Schuh via cfe-commits
https://github.com/AustinSchuh edited https://github.com/llvm/llvm-project/pull/132883 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cuda clang: Add support for CUDA surfaces (PR #132883)

2025-04-04 Thread Austin Schuh via cfe-commits
@@ -0,0 +1,3329 @@ +// RUN: %clang_cc1 -triple nvptx-unknown-unknown -fcuda-is-device -O3 -o - %s -emit-llvm | FileCheck %s +// RUN: %clang_cc1 -triple nvptx64-unknown-unknown -fcuda-is-device -O3 -o - %s -emit-llvm | FileCheck %s +#include "../Headers/Inputs/include/cuda.h" ---

[clang] cuda clang: Add support for CUDA surfaces (PR #132883)

2025-04-04 Thread Artem Belevich via cfe-commits
@@ -0,0 +1,3329 @@ +// RUN: %clang_cc1 -triple nvptx-unknown-unknown -fcuda-is-device -O3 -o - %s -emit-llvm | FileCheck %s +// RUN: %clang_cc1 -triple nvptx64-unknown-unknown -fcuda-is-device -O3 -o - %s -emit-llvm | FileCheck %s +#include "../Headers/Inputs/include/cuda.h" ---

[clang] cuda clang: Add support for CUDA surfaces (PR #132883)

2025-04-03 Thread Austin Schuh via cfe-commits
@@ -0,0 +1,3329 @@ +// RUN: %clang_cc1 -triple nvptx-unknown-unknown -fcuda-is-device -O3 -o - %s -emit-llvm | FileCheck %s +// RUN: %clang_cc1 -triple nvptx64-unknown-unknown -fcuda-is-device -O3 -o - %s -emit-llvm | FileCheck %s +#include "../Headers/Inputs/include/cuda.h" ---

[clang] cuda clang: Add support for CUDA surfaces (PR #132883)

2025-04-03 Thread Jorge Gorbe Moya via cfe-commits
@@ -0,0 +1,3329 @@ +// RUN: %clang_cc1 -triple nvptx-unknown-unknown -fcuda-is-device -O3 -o - %s -emit-llvm | FileCheck %s +// RUN: %clang_cc1 -triple nvptx64-unknown-unknown -fcuda-is-device -O3 -o - %s -emit-llvm | FileCheck %s +#include "../Headers/Inputs/include/cuda.h" ---

[clang] cuda clang: Add support for CUDA surfaces (PR #132883)

2025-04-03 Thread via cfe-commits
github-actions[bot] wrote: @AustinSchuh Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bu

[clang] cuda clang: Add support for CUDA surfaces (PR #132883)

2025-03-29 Thread Austin Schuh via cfe-commits
AustinSchuh wrote: > If the header is compileable without CUDA SDK (maybe with some stub headers > in tests Inputs), then a source file with a lot of builtin calls and > [autogenerated > checks](https://github.com/llvm/llvm-project/blob/d724bab8064685c98cdded88157b6e2245e0d7bc/llvm/utils/updat

[clang] cuda clang: Add support for CUDA surfaces (PR #132883)

2025-03-29 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h -- clang/test/Headers/Inputs/include/surface_indirect_func

[clang] cuda clang: Add support for CUDA surfaces (PR #132883)

2025-03-26 Thread Artem Belevich via cfe-commits
Artem-B wrote: > > LGTM in principle, but it could use some tests. The change is surprisingly > > nicely compact. Thank you for filling in one of the long-standing gaps in > > clang's cuda support story. > > I might need some hints on where to start. How would you go about testing > this, or

[clang] cuda clang: Add support for CUDA surfaces (PR #132883)

2025-03-25 Thread Austin Schuh via cfe-commits
https://github.com/AustinSchuh updated https://github.com/llvm/llvm-project/pull/132883 >From d8ffb5acbd79869476c91433f85488f3088e38fd Mon Sep 17 00:00:00 2001 From: Austin Schuh Date: Mon, 24 Mar 2025 21:42:35 -0700 Subject: [PATCH 1/4] Add support for CUDA surfaces This adds support for all

[clang] cuda clang: Add support for CUDA surfaces (PR #132883)

2025-03-25 Thread Austin Schuh via cfe-commits
https://github.com/AustinSchuh updated https://github.com/llvm/llvm-project/pull/132883 >From d8ffb5acbd79869476c91433f85488f3088e38fd Mon Sep 17 00:00:00 2001 From: Austin Schuh Date: Mon, 24 Mar 2025 21:42:35 -0700 Subject: [PATCH 1/2] Add support for CUDA surfaces This adds support for all

[clang] cuda clang: Add support for CUDA surfaces (PR #132883)

2025-03-24 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] cuda clang: Add support for CUDA surfaces (PR #132883)

2025-03-24 Thread Austin Schuh via cfe-commits
AustinSchuh wrote: @Artem-B I think you added texture support originally. A lot of the language in that file is focused on just textures, not textures and surfaces. I am happy to adjust that if that is desired. I figured a bit ugly, working, and early feedback was preferable. https://github

[clang] cuda clang: Add support for CUDA surfaces (PR #132883)

2025-03-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Austin Schuh (AustinSchuh) Changes This adds support for all the surface read and write calls to clang. It extends the pattern used for textures to surfaces too. I tested this by generating all the various permutations of the calls and a

[clang] cuda clang: Add support for CUDA surfaces (PR #132883)

2025-03-24 Thread Austin Schuh via cfe-commits
https://github.com/AustinSchuh created https://github.com/llvm/llvm-project/pull/132883 This adds support for all the surface read and write calls to clang. It extends the pattern used for textures to surfaces too. I tested this by generating all the various permutations of the calls and argu

[clang] cuda clang: Add support for CUDA surfaces (PR #132883)

2025-03-24 Thread Austin Schuh via cfe-commits
https://github.com/AustinSchuh edited https://github.com/llvm/llvm-project/pull/132883 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits