https://github.com/Artem-B approved this pull request.

Nice.

Now we're missing the two last steps;
- that ptxas accepts the inline asm instructions we generate
- that those instructions actually do what they are intended to do.

Can you manually verify that the test file actually compiles to a GPU binary?
I.e. try to manually compile the test file to .o file, so clang produces PTX 
file and compiles it with ptxas. We do not have ptxas plumbed into testing on 
clang side, so manual verification will do for now.

As for the functional testing, that would need to be done in LLVM test-suite, 
where we do have ability to compile code with actual CUDA SDK, and run it on a 
GPU, but we do not have any functional tests for surfaces, so that's optional.

https://github.com/llvm/llvm-project/pull/132883
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to