[clang] Reland "[analyzer] Harden safeguards for Z3 query times" (PR #97298)

2024-10-10 Thread Balazs Benics via cfe-commits
steakhal wrote: > Thanks for the explanation, I agree with your POV and I don't think that we > need a drastic change like renaming or reordering everything. > > However, in this case I think it would be good to remove the type based > section headers, which are no longer accurate. When someon

[clang] Reland "[analyzer] Harden safeguards for Z3 query times" (PR #97298)

2024-10-09 Thread Donát Nagy via cfe-commits
NagyDonat wrote: Thanks for the explanation, I agree with your POV and I don't think that we need a drastic change like renaming or reordering everything. However, in this case I think it would be good to remove the type based section headers, which are no longer accurate. When someone adds a

[clang] Reland "[analyzer] Harden safeguards for Z3 query times" (PR #97298)

2024-10-09 Thread Balazs Benics via cfe-commits
steakhal wrote: > @steakhal As I was browsing the list of analyzer options, I was surprised to > see that the numerical unsigned options added by this commit are placed in > the "Boolean analyzer options" section of AnalyzerOptions.def. I understand that it's natural to group them together with

[clang] Reland "[analyzer] Harden safeguards for Z3 query times" (PR #97298)

2024-10-09 Thread Donát Nagy via cfe-commits
NagyDonat wrote: @steakhal As I was browsing the list of analyzer options, I was surprised to see that the numerical `unsigned` options added by this commit are placed in the "Boolean analyzer options" section of `AnalyzerOptions.def`. I understand that it's natural to group them together with

[clang] Reland "[analyzer] Harden safeguards for Z3 query times" (PR #97298)

2024-07-01 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/97298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland "[analyzer] Harden safeguards for Z3 query times" (PR #97298)

2024-07-01 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat approved this pull request. This should be re-landed as well; when it was merged earlier the only issue was the incompatibility with old Z3 and that was addressed since then (by bumping the version requirement). https://github.com/llvm/llvm-project/pull/97298 _

[clang] Reland "[analyzer] Harden safeguards for Z3 query times" (PR #97298)

2024-07-01 Thread Balazs Benics via cfe-commits
steakhal wrote: This is the continuation patch of #97265. https://github.com/llvm/llvm-project/pull/97298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland "[analyzer] Harden safeguards for Z3 query times" (PR #97298)

2024-07-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 @llvm/pr-subscribers-clang Author: Balazs Benics (steakhal) Changes This is exactly as originally landed in #95129, but now the minimal Z3 version was increased to meet this change in #96682. https://discourse.llvm.org/t/bump-min

[clang] Reland "[analyzer] Harden safeguards for Z3 query times" (PR #97298)

2024-07-01 Thread Balazs Benics via cfe-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/97298 This is exactly as originally landed in #95129, but now the minimal Z3 version was increased to meet this change in #96682. https://discourse.llvm.org/t/bump-minimal-z3-requirements-from-4-7-1-to-4-8-9/79664/4