vbe-sc wrote:
@glandium, I've provided the fix in this PR
(https://github.com/llvm/llvm-project/pull/119024).
https://github.com/llvm/llvm-project/pull/118003
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
vbe-sc wrote:
> I was creducing it (well, cvise-ing). Here's a reproducer:
>
> ```
> template struct MozPromise {
> class Private;
>
> private:
> void *mMagic4;
> };
> template
> struct MozPromise::Private
> : MozPromise {
> void SetTaskPriority() { mMagic4 }
> }
> ```
Thanks, I'll
glandium wrote:
I was creducing it (well, cvise-ing). Here's a reproducer:
```
template struct MozPromise {
class Private;
private:
void *mMagic4;
};
template
struct MozPromise::Private
: MozPromise {
void SetTaskPriority() { mMagic4 }
}
```
https://github.com/llvm/llvm-project/pull
vbe-sc wrote:
> I'm hitting an assertion on some Firefox code after this landed:
>
> ```
> clang++: /tmp/llvm/llvm/include/llvm/Support/Casting.h:566: decltype(auto)
> llvm::cast(const From &) [To = cl
> ang::RecordType, From = clang::QualType]: Assertion `isa(Val) &&
> "cast() argument of inc
https://github.com/asi-sc closed
https://github.com/llvm/llvm-project/pull/118003
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/118003
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane approved this pull request.
Please give @cor3ntin 48 hrs from now to have a chance to review this before
committing.
https://github.com/llvm/llvm-project/pull/118003
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
vbe-sc wrote:
@cor3ntin, FYI: we reverted the patch you merged before. This is the second
attempt
https://github.com/llvm/llvm-project/pull/118003
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
https://github.com/zwuis approved this pull request.
https://github.com/llvm/llvm-project/pull/118003
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1178,17 +1178,61 @@ namespace cwg590 { // cwg590: yes
template typename A::B::C A::B::C::f(A::B::C) {}
}
-namespace cwg591 { // cwg591: no
+namespace cwg591 { // cwg591: yes
vbe-sc wrote:
Done
https://github.com/llvm/llvm-project/pull/118003
__
@@ -3599,7 +3599,7 @@ C++ defect report implementation
status
https://cplusplus.github.io/CWG/issues/591.html";>591
CD4
When a dependent base class is the current instantiation
-No
+Yes
vbe-sc wrote:
Done
https://github.com/llvm/llvm-proj
https://github.com/vbe-sc updated
https://github.com/llvm/llvm-project/pull/118003
>From 98583ff617a4d527041c683e98904ed063467c50 Mon Sep 17 00:00:00 2001
From: vb-sc
Date: Tue, 5 Nov 2024 15:46:57 +0300
Subject: [PATCH] [clang] Fix name lookup for dependent bases
---
clang/docs/ReleaseNotes.
@@ -3599,7 +3599,7 @@ C++ defect report implementation
status
https://cplusplus.github.io/CWG/issues/591.html";>591
CD4
When a dependent base class is the current instantiation
-No
+Yes
zwuis wrote:
```suggestion
Clang 20
```
https:/
@@ -1178,17 +1178,61 @@ namespace cwg590 { // cwg590: yes
template typename A::B::C A::B::C::f(A::B::C) {}
}
-namespace cwg591 { // cwg591: no
+namespace cwg591 { // cwg591: yes
zwuis wrote:
```suggestion
namespace cwg591 { // cwg591: 20
```
https://githu
https://github.com/vbe-sc edited
https://github.com/llvm/llvm-project/pull/118003
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vbe-sc wrote:
@erichkeane, @nikic This is the second version of this patch. I’m not entirely
sure if my suggestion regarding the redundant assertion is correct, but I’d
like to share some thoughts on the clang build time regression:
According to the actual implementation of `CXXRecordDecl::loo
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Vladislav Belov (vbe-sc)
Changes
Unlike the previous version, this patch also removes an unnecessary assert that
causes Clang to crash when compiling such tests. (clang/lib/AST/DeclCXX.cpp)
https://lab.llvm.org/buildbot/#/builders/52/buil
https://github.com/vbe-sc created
https://github.com/llvm/llvm-project/pull/118003
Unlike the previous version, this patch also removes an unnecessary assert that
causes Clang to crash when compiling such tests. (clang/lib/AST/DeclCXX.cpp)
https://lab.llvm.org/buildbot/#/builders/52/builds/402
18 matches
Mail list logo
