[clang] Fix crash with invalid member function param list (PR #139595)

2025-05-13 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/139595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix crash with invalid member function param list (PR #139595)

2025-05-13 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/139595 Rate limit ยท GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,s

[clang] Fix crash with invalid member function param list (PR #139595)

2025-05-12 Thread Erich Keane via cfe-commits
@@ -40,3 +40,13 @@ struct S : public Base1, public Base2 { // All initializers are correct, nothing to skip, diagnose 2 missing commas. S(const S &) : Base1(0) ::Base2(1.0) x(2) {} // expected-error2{{missing ',' between base or member initializers}} }; + +namespace GH1137

[clang] Fix crash with invalid member function param list (PR #139595)

2025-05-12 Thread Aaron Ballman via cfe-commits
@@ -40,3 +40,13 @@ struct S : public Base1, public Base2 { // All initializers are correct, nothing to skip, diagnose 2 missing commas. S(const S &) : Base1(0) ::Base2(1.0) x(2) {} // expected-error2{{missing ',' between base or member initializers}} }; + +namespace GH1137

[clang] Fix crash with invalid member function param list (PR #139595)

2025-05-12 Thread Erich Keane via cfe-commits
@@ -40,3 +40,13 @@ struct S : public Base1, public Base2 { // All initializers are correct, nothing to skip, diagnose 2 missing commas. S(const S &) : Base1(0) ::Base2(1.0) x(2) {} // expected-error2{{missing ',' between base or member initializers}} }; + +namespace GH1137

[clang] Fix crash with invalid member function param list (PR #139595)

2025-05-12 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/139595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix crash with invalid member function param list (PR #139595)

2025-05-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes We cannot consume annotation tokens with ConsumeToken(), so any pragmas present in an invalid initializer would previously crash. Now we handle annotation tokens more generally and avoid the crash. Fi

[clang] Fix crash with invalid member function param list (PR #139595)

2025-05-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/139595 We cannot consume annotation tokens with ConsumeToken(), so any pragmas present in an invalid initializer would previously crash. Now we handle annotation tokens more generally and avoid the crash. Fixes