https://github.com/higher-performance closed
https://github.com/llvm/llvm-project/pull/90634
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
higher-performance wrote:
Thanks! I'll close this for now then.
https://github.com/llvm/llvm-project/pull/90634
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
philnik777 wrote:
While the libc++ checks are in the same tree as clang-tidy itself we (libc++)
don't actually consider them in-tree, since they are compiled as a plugin
against a clang-tidy that's already installed on the system.
https://github.com/llvm/llvm-project/pull/90634
___
higher-performance wrote:
@AaronBallman that makes sense, thanks! For `isTrivial`, I do see it is used in
two places, but they're not fully compatible (one operates on `QualType`, and
neither works on methods):
-
https://github.com/llvm/llvm-project/blob/ebe77cc320a1bcc8e2cec44f4f388fb43b7201
@@ -5444,6 +5444,43 @@ AST_MATCHER(FunctionDecl, isDefaulted) {
return Node.isDefaulted();
}
+/// Matches trivial methods and types.
higher-performance wrote:
Ah I see, yeah. I don't think we want to support that since the other matchers
don't do that eith
AaronBallman wrote:
Thanks for the details! I'd say let's hold off on adding these matchers; if you
have a check that needs them, then you could look through clang-tidy to see if
other checks have also added a local matcher for the same thing, and if there's
two or more matchers needing it, th
higher-performance wrote:
@AaronBallman: Oh I see. I didn't have any plans to upstream any matchers that
used this, though I suppose I could. The check I had in mind though ostensibly
could be in-tree, if you guys were interested. Though now that I think about it
more, I think it would need `i
AaronBallman wrote:
> I remember back in the day that adding new matchers was a problem because it
> grew the size of the files beyond some supported compiler's limit.
>
> Could @AaronBallman or someone else knowledgable about this(cc @kadircet)
> take a look and confirm adding matchers is fin
@@ -5444,6 +5444,43 @@ AST_MATCHER(FunctionDecl, isDefaulted) {
return Node.isDefaulted();
}
+/// Matches trivial methods and types.
ilya-biryukov wrote:
I do not think is actually matches `types`, but rather `classes` or
`CXXRecordDecl`.
And the question
https://github.com/ilya-biryukov requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/90634
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov wrote:
I remember back in the day that adding new matchers was a problem because it
grew the size of the files beyond some supported compiler's limit.
Could @AaronBallman or someone else knowledgable about this(cc @kadircet) take
a look and confirm adding matchers is fine now?
h
https://github.com/higher-performance updated
https://github.com/llvm/llvm-project/pull/90634
>From f981f44824d9387fde221e2aa0e260802f3d67f2 Mon Sep 17 00:00:00 2001
From: higher-performance
Date: Tue, 30 Apr 2024 14:40:59 -0600
Subject: [PATCH] Add isTrivial() and isTriviallyCopyable() AST mat
https://github.com/higher-performance updated
https://github.com/llvm/llvm-project/pull/90634
>From a58dbe94dde39b44065321fd2d3444332536c778 Mon Sep 17 00:00:00 2001
From: higher-performance
Date: Tue, 30 Apr 2024 14:40:59 -0600
Subject: [PATCH] Add isTrivial() and isTriviallyCopyable() AST mat
higher-performance wrote:
Hi, is this a new requirement? I don't wish to commit my personal information
here. What are my options?
https://github.com/llvm/llvm-project/pull/90634
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.ll
https://github.com/higher-performance updated
https://github.com/llvm/llvm-project/pull/90634
>From 013b692fbd8ec3aab4913b65582e11c5be566c77 Mon Sep 17 00:00:00 2001
From: higher-performance
<113926381+higher-performa...@users.noreply.github.com>
Date: Tue, 30 Apr 2024 14:40:59 -0600
Subject: [
github-actions[bot] wrote:
⚠️ We detected that you are using a GitHub private e-mail address to contribute
to the repo. Please turn off [Keep my email addresses
private](https://github.com/settings/emails) setting in your account. See
[LLVM
Discourse](https://discourse.llvm.org/t/hidden-email
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (higher-performance)
Changes
There are currently no AST matchers for the equivalent of `std::is_trivial`,
`std::is_trivially_default_constructible`, `std::is_trivially_copyable`, and
the like.
This pull request adds matchers to chec
https://github.com/higher-performance created
https://github.com/llvm/llvm-project/pull/90634
There are currently no AST matchers for the equivalent of `std::is_trivial`,
`std::is_trivially_default_constructible`, `std::is_trivially_copyable`, and
the like.
This pull request adds matchers to
18 matches
Mail list logo
