momchil-velikov wrote:
Abandon for now, the follow-up patch
(https://github.com/llvm/llvm-project/pull/121802) was reduced in scope and
does not need to update tests.
https://github.com/llvm/llvm-project/pull/121801
___
cfe-commits mailing list
cfe-c
https://github.com/momchil-velikov closed
https://github.com/llvm/llvm-project/pull/121801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
momchil-velikov wrote:
> Instead it could perform a load with the original type and then emit an LLVM
> IR `bitcast`, just like it does for "C-style"
Except that it does not work when aggregate types are involved.
Using `mem2reg,sroa` is a bit better than just `mem2reg`, even though `sroa`
gen
momchil-velikov wrote:
Another things that "works" is changing the codegen for `__builtin_bit_cast`
(https://github.com/llvm/llvm-project/blob/32bc029be6265838833623fdd88cc665d5658dc7/clang/lib/CodeGen/CGExprScalar.cpp#L2295).
It stores a value with one type and loads it back with another type w
davemgreen wrote:
sroa would be ideal if it works, I know a number of test cases use it and it
shouldn't update too often.
https://github.com/llvm/llvm-project/pull/121801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
momchil-velikov wrote:
> > This patch adds instcombine to some tests that were passing
> Can the instcombines be replaced with something simpler like dce or maybe
> instsimplify? It might be OK with just mem2reg.
Unfortunately just `mem2reg` does not cut it. The original issue it that Clang
ge
https://github.com/momchil-velikov edited
https://github.com/llvm/llvm-project/pull/121801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
davemgreen wrote:
> This patch adds instcombine to some tests that were passing
This patch sounds good, but the intent of the clang tests is that they should
not be dependant on the mid-end optimizations in llvm. At least for
fast-changing parts like instcombine, where you don't want to have t
https://github.com/jthackray approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/121801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
7cb6e6bced8ca5767c3e609f4826982638fd9543...67ba481f809abdc85a90fed5ff11ca48c6578e3e
llvm/
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Momchil Velikov (momchil-velikov)
Changes
This patch adds `instcombine` to some tests that were passing
Clang's output to `opt -S --passes=mem2reg`, and converts some
other tests to using `update_cc_test_checks.py`.
Assembly part of some t
11 matches
Mail list logo
