davemgreen wrote: > This patch adds instcombine to some tests that were passing
This patch sounds good, but the intent of the clang tests is that they should not be dependant on the mid-end optimizations in llvm. At least for fast-changing parts like instcombine, where you don't want to have to update a thousand clang tests every time instcombine learns a new trick. The clang tests should ideally be testing the clang output. Can the instcombines be replaced with something simpler like dce or maybe instsimplify? It might be OK with just mem2reg. https://github.com/llvm/llvm-project/pull/121801 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
