erichkeane wrote:
> > Requesting changes just to be sure none of the changes from `createRef()`
> > to `createDup()` would have generated a `StringRef` holding a null pointer.
> > I'd be surprised if they did, but a second set of eyes would be helpful.
>
> I am not sure how to proceed here. Th
vitalybuka wrote:
> Requesting changes just to be sure none of the changes from `createRef()` to
> `createDup()` would have generated a `StringRef` holding a null pointer. I'd
> be surprised if they did, but a second set of eyes would be helpful.
I am not sure how to proceed here.
This change
@@ -77,19 +77,6 @@ CXString createDup(const char *String) {
return Str;
}
-CXString createRef(StringRef String) {
- if (!String.data())
-return createNull();
-
- // If the string is empty, it might point to a position in another string
- // while having zero length. M
https://github.com/AaronBallman requested changes to this pull request.
Requesting changes just to be sure none of the changes from `createRef()` to
`createDup()` would have generated a `StringRef` holding a null pointer. I'd be
surprised if they did, but a second set of eyes would be helpful.
@@ -77,19 +77,6 @@ CXString createDup(const char *String) {
return Str;
}
-CXString createRef(StringRef String) {
- if (!String.data())
-return createNull();
-
- // If the string is empty, it might point to a position in another string
- // while having zero length. M
https://github.com/AaronBallman approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/126683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/126683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -77,19 +77,6 @@ CXString createDup(const char *String) {
return Str;
}
-CXString createRef(StringRef String) {
- if (!String.data())
-return createNull();
-
- // If the string is empty, it might point to a position in another string
- // while having zero length. M
https://github.com/egorzhdan approved this pull request.
I'm not an expert in the area, but this change LGTM.
https://github.com/llvm/llvm-project/pull/126683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/126683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
10 matches
Mail list logo
