================ @@ -77,19 +77,6 @@ CXString createDup(const char *String) { return Str; } -CXString createRef(StringRef String) { - if (!String.data()) - return createNull(); - - // If the string is empty, it might point to a position in another string - // while having zero length. Make sure we don't create a reference to the - // larger string. - if (String.empty()) ---------------- AaronBallman wrote:
We're not losing those checks -- `createDup()` has them: https://github.com/llvm/llvm-project/blob/8337d01e3058e7f47675f5b2b908b4e7821895d7/clang/tools/libclang/CXString.cpp#L67 https://github.com/llvm/llvm-project/pull/126683 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits