[clang] [clang] replaced the usage of `asctime` with `std::put_time` (PR #99075)

rorth wrote: > > At least in the short term. ISTM that `clang++` may need to do something > > along the lines of Bug 33767 (resp. the underlying GCC bug/patch), > > otherwise users are in for a nasty surprise. > > Agreed; long-term we need a better solution. Hopefully someone maintaining > So

[clang] [clang] replaced the usage of `asctime` with `std::put_time` (PR #99075)

yichi170 wrote: Thanks for identifying the problem. @AaronBallman @rorth https://github.com/llvm/llvm-project/pull/99075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] replaced the usage of `asctime` with `std::put_time` (PR #99075)

rorth wrote: At least in the short term. ISTM that `clang++` may need to do something along the lines of Bug 33767 (resp. the underlying GCC bug/patch), otherwise users are in for a nasty surprise. https://github.com/llvm/llvm-project/pull/99075 ___

[clang] [clang] replaced the usage of `asctime` with `std::put_time` (PR #99075)

AaronBallman wrote: Blech, thank you for trying! I guess that unless there's some way to hide this ugliness in the cmake scripts or someone else has better ideas to try, the `asm` aliasing (on Solaris only) may be our best path forward. https://github.com/llvm/llvm-project/pull/99075 _

[clang] [clang] replaced the usage of `asctime` with `std::put_time` (PR #99075)

rorth wrote: > If you dump the symbols from the STL shared library on the system, is there > one for `time_put` at all? If so, what is the mangled symbol it exports? While the source requires ``` _ZNKSt8time_putIcSt19ostreambuf_iteratorIcSt11char_traitsIcEEE3putES3_RSt8ios_basecPKSt2tmPKcSB_ s

[clang] [clang] replaced the usage of `asctime` with `std::put_time` (PR #99075)

AaronBallman wrote: > > We have a mixture of both `std::tm` and `::tm` in here, try switching to > > using `::tm` and see if that helps. > > Unfortunately not: I always get the undefined reference to the `std::tm const > *` version, no matter what I tried. Drat! If you dump the symbols from

[clang] [clang] replaced the usage of `asctime` with `std::put_time` (PR #99075)

rorth wrote: > Aha! > > https://bugs.llvm.org/show_bug.cgi?id=33767 Ah, old sins (from the GCC side no less) keep haunting me. > We have a mixture of both `std::tm` and `::tm` in here, try switching to > using `::tm` and see if that helps. Unfortunately not: I always get the undefined refere

[clang] [clang] replaced the usage of `asctime` with `std::put_time` (PR #99075)

AaronBallman wrote: Aha! https://bugs.llvm.org/show_bug.cgi?id=33767 We have a mixture of both `std::tm` and `::tm` in here, try switching to using `::tm` and see if that helps. https://github.com/llvm/llvm-project/pull/99075 ___ cfe-commits mailing

[clang] [clang] replaced the usage of `asctime` with `std::put_time` (PR #99075)

AaronBallman wrote: > Confirmed: reverting the change locally restores the builds, although I don't > yet see why. The fact that there's a missing symbol suggests the STL on the machine is not conforming... the symbol that's missing (`_ZNKSt8time_putIcSt19ostreambuf_iteratorIcSt11char_traits

[clang] [clang] replaced the usage of `asctime` with `std::put_time` (PR #99075)

rorth wrote: This seems to have broken the [Solaris/amd64](https://lab.llvm.org/staging/#/builders/120/builds/187) and [Solaris/sparcv9](https://lab.llvm.org/buildbot/#/builders/13/builds/1030) buildbots. https://github.com/llvm/llvm-project/pull/99075

[clang] [clang] replaced the usage of `asctime` with `std::put_time` (PR #99075)

github-actions[bot] wrote: @yichi170 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build

[clang] [clang] replaced the usage of `asctime` with `std::put_time` (PR #99075)

https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/99075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] replaced the usage of `asctime` with `std::put_time` (PR #99075)

cor3ntin wrote: LGTM too! Thanks for the fix :) https://github.com/llvm/llvm-project/pull/99075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] replaced the usage of `asctime` with `std::put_time` (PR #99075)

https://github.com/yichi170 updated https://github.com/llvm/llvm-project/pull/99075 >From 60a8a36851bcb0e73228ec4941f1906d0e5b7ba9 Mon Sep 17 00:00:00 2001 From: yichi170 Date: Wed, 17 Jul 2024 02:15:43 +0800 Subject: [PATCH] [clang] replaced the usage of `asctime` with `std::put_time` --- cl

[clang] [clang] replaced the usage of `asctime` with `std::put_time` (PR #99075)

yichi170 wrote: I don't have write access, so if the PR is ready, please help me land it! If there is anything that I need to do, please let me know! https://github.com/llvm/llvm-project/pull/99075 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [clang] replaced the usage of `asctime` with `std::put_time` (PR #99075)

https://github.com/yichi170 edited https://github.com/llvm/llvm-project/pull/99075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] replaced the usage of `asctime` with `std::put_time` (PR #99075)

https://github.com/yichi170 edited https://github.com/llvm/llvm-project/pull/99075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits