[clang] [clang] add llvm abi support (PR #121123)

2025-01-06 Thread Tristan Ross via cfe-commits
RossComputerGuy wrote: > That said, I tend to agree with the review at [#121123 > (comment)](https://github.com/llvm/llvm-project/pull/121123#discussion_r1900548165) > that this doesn't seem like the right approach. Yeah I agree too, I'm not sure what the right approach is but that's one of th

[clang] [clang] add llvm abi support (PR #121123)

2025-01-06 Thread Carlo Cabrera via cfe-commits
carlocab wrote: > Introducing a target triple has large ecosystem implication and should not be > taken lightly. To be fair this patch doesn't introduce a target triple, it only makes it more easily usable in Clang. That said, I tend to agree with the review at https://github.com/llvm/llvm-

[clang] [clang] add llvm abi support (PR #121123)

2025-01-06 Thread Joseph Huber via cfe-commits
jhuber6 wrote: You can compile and run static C applications, I'm not sure what the threshold is before we can start adding support to make it usable in `clang`. https://github.com/llvm/llvm-project/pull/121123 ___ cfe-commits mailing list cfe-commits

[clang] [clang] add llvm abi support (PR #121123)

2025-01-06 Thread Tristan Ross via cfe-commits
RossComputerGuy wrote: Why close? LLVM libc is maturing and one of the goals I had was to try using it in Nixpkgs to build whatever I can. LLVM libc doesn't work well in an overlay mode so we have to use full builds. It's true that a lot of functions are still missing or not implemented but by

[clang] [clang] add llvm abi support (PR #121123)

2025-01-06 Thread Tristan Ross via cfe-commits
@@ -1531,7 +1531,7 @@ Compilation *Driver::BuildCompilation(ArrayRef ArgList) { // Check if the environment version is valid except wasm case. llvm::Triple Triple = TC.getTriple(); - if (!Triple.isWasm()) { + if (!Triple.isWasm() && Triple.getEnvironment() != llvm::Tripl

[clang] [clang] add llvm abi support (PR #121123)

2025-01-06 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/121123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] add llvm abi support (PR #121123)

2025-01-06 Thread Fangrui Song via cfe-commits
MaskRay wrote: NAK. While llvm libc can be used an overlay, it is not complete for standalone Linux server/desktop usage. Introducing a target triple has large ecosystem implication and should not be taken lightly. https://github.com/llvm/llvm-project/pull/121123 _

[clang] [clang] add llvm abi support (PR #121123)

2025-01-06 Thread Chris B via cfe-commits
@@ -1531,7 +1531,7 @@ Compilation *Driver::BuildCompilation(ArrayRef ArgList) { // Check if the environment version is valid except wasm case. llvm::Triple Triple = TC.getTriple(); - if (!Triple.isWasm()) { + if (!Triple.isWasm() && Triple.getEnvironment() != llvm::Tripl

[clang] [clang] add llvm abi support (PR #121123)

2024-12-26 Thread Tristan Ross via cfe-commits
https://github.com/RossComputerGuy updated https://github.com/llvm/llvm-project/pull/121123 >From f5ef9c9fc9aac6058f5dd070f9e24932b4e4cf9a Mon Sep 17 00:00:00 2001 From: Tristan Ross Date: Wed, 25 Dec 2024 14:38:30 -0800 Subject: [PATCH] [clang] add llvm abi support --- clang/lib/Driver/Drive

[clang] [clang] add llvm abi support (PR #121123)

2024-12-26 Thread Carlo Cabrera via cfe-commits
https://github.com/carlocab commented: Needs tests. https://github.com/llvm/llvm-project/pull/121123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] add llvm abi support (PR #121123)

2024-12-25 Thread Tristan Ross via cfe-commits
https://github.com/RossComputerGuy updated https://github.com/llvm/llvm-project/pull/121123 >From 23922b886739b2e298e4288dd53d6f59e8e2e86e Mon Sep 17 00:00:00 2001 From: Tristan Ross Date: Wed, 25 Dec 2024 14:38:30 -0800 Subject: [PATCH] [clang] add llvm abi support --- clang/lib/Driver/Drive

[clang] [clang] add llvm abi support (PR #121123)

2024-12-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Tristan Ross (RossComputerGuy) Changes This PR makes it possible to use the LLVM ABI which uses LLVM libc. --- Full diff: https://github.com/llvm/llvm-project/pull/121123.diff 2 Files Affected: - (modif

[clang] [clang] add llvm abi support (PR #121123)

2024-12-25 Thread Tristan Ross via cfe-commits
https://github.com/RossComputerGuy created https://github.com/llvm/llvm-project/pull/121123 This PR makes it possible to use the LLVM ABI which uses LLVM libc. >From 058c4d297822cbde97641eb9c35d78d5742b96f2 Mon Sep 17 00:00:00 2001 From: Tristan Ross Date: Wed, 25 Dec 2024 14:38:30 -0800 Subje