================
@@ -1531,7 +1531,7 @@ Compilation *Driver::BuildCompilation(ArrayRef<const char 
*> ArgList) {
 
   // Check if the environment version is valid except wasm case.
   llvm::Triple Triple = TC.getTriple();
-  if (!Triple.isWasm()) {
+  if (!Triple.isWasm() && Triple.getEnvironment() != llvm::Triple::LLVM) {
----------------
llvm-beanz wrote:

This seems wrong to me. Opting out of here makes me think there is something 
wrong with how the LLVM environment was implemented in the triple.

The Wasm case is special because (apparently) it is supported to pass arbitrary 
non-environment values in the triple (see discussion: 
https://github.com/llvm/llvm-project/pull/78655#issuecomment-1928458721).

https://github.com/llvm/llvm-project/pull/121123
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to