llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`sanitizer-aarch64-linux-bootstrap-ubsan` running on `sanitizer-buildbot10`
while building `clang` at step 2 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/85/builds/9036
Here is the rele
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`clang-aarch64-sve2-vla-2stage` running on `linaro-g4-02` while building
`clang` at step 12 "ninja check 2".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/199/builds/3562
Here is the relevant piece
github-actions[bot] wrote:
@matts1 Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a build,
https://github.com/ChuanqiXu9 closed
https://github.com/llvm/llvm-project/pull/131569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ChuanqiXu9 approved this pull request.
https://github.com/llvm/llvm-project/pull/131569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/matts1 updated
https://github.com/llvm/llvm-project/pull/131569
>From 5ab93bd5c9ae1a58e15bae43e329afd4277f76c4 Mon Sep 17 00:00:00 2001
From: Matt Stark
Date: Mon, 10 Mar 2025 12:09:49 +1100
Subject: [PATCH] [clang] Mark some language options as benign.
I'm fairly certain t
matts1 wrote:
I've rebased to fix merge conflicts, could someone please approve and submit
this?
https://github.com/llvm/llvm-project/pull/131569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/c
https://github.com/matts1 updated
https://github.com/llvm/llvm-project/pull/131569
>From 2507e992742c067948021a5c07379abe725cf52d Mon Sep 17 00:00:00 2001
From: Matt Stark
Date: Mon, 10 Mar 2025 12:09:49 +1100
Subject: [PATCH] [clang] Mark some language options as benign.
I'm fairly certain t
https://github.com/matts1 updated
https://github.com/llvm/llvm-project/pull/131569
Rate limit ยท GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-se
https://github.com/Bigcheese approved this pull request.
lgtm with Chuanqi's release notes request.
Separately, I'd also like to see the rtti and exceptions stuff be marked
compatible, although with some testing first of what happens when people do
create AST differences with the macros. It's
@@ -398,11 +398,11 @@ BENIGN_LANGOPT(HalfNoSemanticInterposition, 1, 0,
"Like -fno-semantic-interposition but don't use local aliases")
ENUM_LANGOPT(StackProtector, StackProtectorMode, 2, SSPOff,
"stack protector mode")
-ENUM_LANGOPT(TrivialAutoVarIn
cor3ntin wrote:
I think this looks fine but I'd like @Bigcheese @erichkeane @AaronBallman to
look at it too.
https://github.com/llvm/llvm-project/pull/131569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
erichkeane wrote:
> I think this looks fine but I'd like @Bigcheese @erichkeane @AaronBallman to
> look at it too.
This looks fine as far as I can tell. Though, I'm not sure I have sufficient
knowledge to be comfortable enough with the implications to approve this.
@Bigcheese and @ChuanqiXu9
mizvekov wrote:
I think one option would be to allow differences in macros, and rely on the ODR
checker to catch when that would cause problems.
https://github.com/llvm/llvm-project/pull/131569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
matts1 wrote:
> The issue is that if we allow the preprocessor's state to differ across
> modules, then the resulting compiled units can be arbitrary (and subtly
> incompatible).
>
> I wonder if a possible solution is to record which macros are used (ie, are
> expanded or appear in `#ifdef` /
atetubou wrote:
Could you update issue description too?
https://github.com/llvm/llvm-project/pull/131569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Bigcheese wrote:
The general issue with changing this to benign is that it ends up being
non-deterministic and buggy for implicitly built modules. I think what we want
here is `COMPATIBLE_LANGOPT`. By default it will still feed into the context
hash, but the compiler won't reject loading such
cor3ntin wrote:
The issue is that if we allow the preprocessor's state to differ across
modules, then the resulting compiled units can be arbitrary (and subtly
incompatible).
I wonder if a possible solution is to record which macros are used (ie, are
expanded or appear in `#ifdef` / `defined`
matts1 wrote:
For now I've removed everything but the TrivialAuto*
https://github.com/llvm/llvm-project/pull/131569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/matts1 updated
https://github.com/llvm/llvm-project/pull/131569
>From f53415b24c0cf9da6ac4e5c563dc46e72c224d2e Mon Sep 17 00:00:00 2001
From: Matt Stark
Date: Mon, 10 Mar 2025 12:09:49 +1100
Subject: [PATCH] [clang] Mark some language options as benign.
I'm fairly certain t
matts1 wrote:
Thanks for the review, what you said makes sense. This is extremely important
for us that we can get this to work though, so I was wondering if there was
some way we could work around it. I'll use the `rtti` flag for all future
examples.
Firstly, to check that I understand corre
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/131569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin commented:
Changes to TrivialAuto* seem fine, everything else is observable through macros
:(
https://github.com/llvm/llvm-project/pull/131569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
@@ -139,18 +139,18 @@ ENUM_LANGOPT(AltivecSrcCompat, AltivecSrcCompatKind, 2,
LANGOPT(ConvergentFunctions, 1, 1, "Assume convergent functions")
LANGOPT(AltiVec , 1, 0, "AltiVec-style vector initializers")
LANGOPT(ZVector , 1, 0, "System z vector extensions")
@@ -139,18 +139,18 @@ ENUM_LANGOPT(AltivecSrcCompat, AltivecSrcCompatKind, 2,
LANGOPT(ConvergentFunctions, 1, 1, "Assume convergent functions")
LANGOPT(AltiVec , 1, 0, "AltiVec-style vector initializers")
LANGOPT(ZVector , 1, 0, "System z vector extensions")
@@ -397,13 +397,13 @@
BENIGN_ENUM_LANGOPT(ExternDeclNoDLLStorageClassVisibility, VisibilityFromDLLStor
BENIGN_LANGOPT(SemanticInterposition, 1, 0, "semantic interposition")
BENIGN_LANGOPT(HalfNoSemanticInterposition, 1, 0,
"Like -fno-semantic-interpositi
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Matt (matts1)
Changes
I'm fairly certain that the options in this CL are benign, as I don't believe
they affect the AST.
* RTTI - shouldn't affect the AST, should only affect codegen
* Trivial var init - also should only affect codegen
*
https://github.com/matts1 created
https://github.com/llvm/llvm-project/pull/131569
I'm fairly certain that the options in this CL are benign, as I don't believe
they affect the AST.
* RTTI - shouldn't affect the AST, should only affect codegen
* Trivial var init - also should only affect codeg
29 matches
Mail list logo
