Bigcheese wrote:

The general issue with changing this to benign is that it ends up being 
non-deterministic and buggy for implicitly built modules. I think what we want 
here is `COMPATIBLE_LANGOPT`. By default it will still feed into the context 
hash, but the compiler won't reject loading such modules. If Chrome plans to 
use explicitly built modules then this is fine.

There are quite a few options we could change to compatible, but the big issues 
is in making sure that Clang won't crash when we do that. I think for RTTI it's 
fine as that should only impact the predefine and codegen, not the shape of the 
AST. Sadly we have no good way to test this in general, just on a case by case 
basis when we hit issues.

https://github.com/llvm/llvm-project/pull/131569
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to