@@ -12519,16 +12519,13 @@ def err_builtin_is_within_lifetime_invalid_arg :
Error<
"%select{non-|function }0pointer argument to '__builtin_is_within_lifetime' "
"is not allowed">;
-def err_builtin_invalid_arg_type: Error <
- "%ordinal0 argument must be "
- "%select{a vec
https://github.com/frasercrmck closed
https://github.com/llvm/llvm-project/pull/125673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
https://github.com/llvm/llvm-project/pull/125673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
frasercrmck wrote:
ping. This PR is blocking the addition of some new elementwise builtins we want
for libclc.
https://github.com/llvm/llvm-project/pull/125673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/125673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
frasercrmck wrote:
ping, thanks
https://github.com/llvm/llvm-project/pull/125673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/farzonl approved this pull request.
As far as the HLSL changes go. This looks fine to me. Approved! Please wait for
other stakholders before merging.
https://github.com/llvm/llvm-project/pull/125673
___
cfe-commits mailing list
cfe-
@@ -2266,8 +2266,10 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned
BuiltinID, CallExpr *TheCall) {
if (CheckVectorElementCallArgs(&SemaRef, TheCall))
return true;
if (SemaRef.BuiltinElementwiseTernaryMath(
-TheCall, /*CheckForFloatArgs*/
-
@@ -2266,8 +2266,10 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned
BuiltinID, CallExpr *TheCall) {
if (CheckVectorElementCallArgs(&SemaRef, TheCall))
return true;
if (SemaRef.BuiltinElementwiseTernaryMath(
-TheCall, /*CheckForFloatArgs*/
-
@@ -12411,16 +12411,13 @@ def err_builtin_is_within_lifetime_invalid_arg :
Error<
"%select{non-|function }0pointer argument to '__builtin_is_within_lifetime' "
"is not allowed">;
-def err_builtin_invalid_arg_type: Error <
- "%ordinal0 argument must be "
- "%select{a vec
@@ -12411,16 +12411,13 @@ def err_builtin_is_within_lifetime_invalid_arg :
Error<
"%select{non-|function }0pointer argument to '__builtin_is_within_lifetime' "
"is not allowed">;
-def err_builtin_invalid_arg_type: Error <
- "%ordinal0 argument must be "
- "%select{a vec
@@ -12411,16 +12411,13 @@ def err_builtin_is_within_lifetime_invalid_arg :
Error<
"%select{non-|function }0pointer argument to '__builtin_is_within_lifetime' "
"is not allowed">;
-def err_builtin_invalid_arg_type: Error <
- "%ordinal0 argument must be "
- "%select{a vec
frasercrmck wrote:
ping, thanks
https://github.com/llvm/llvm-project/pull/125673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
frasercrmck wrote:
> There are a couple of things I thought I'd leave to the PR discussion, like:
>
> * Should we standardise the diagnostics a bit better? Specifically with
> regards to whether the possibility of "vector" needs to be made explicit when
> we say `a floating point type`, `a
frasercrmck wrote:
> This PR has me thinking about a related problem.
>
> In HLSL we have elementwise builtins like `__builtin_hlsl_elementwise_frac`.
> We do not add the `CustomTypeChecking` attribute to these builtins. This puts
> us down the variadic type check rules for scalar inputs to th
@@ -2393,8 +2395,10 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned
BuiltinID, CallExpr *TheCall) {
if (CheckVectorElementCallArgs(&SemaRef, TheCall))
return true;
if (SemaRef.BuiltinElementwiseTernaryMath(
-TheCall, /*CheckForFloatArgs*/
-
farzonl wrote:
This PR has me thinking about a related problem.
In HLSL we have elementwise builtins like `__builtin_hlsl_elementwise_frac`.
We do not add the `CustomTypeChecking` attribute to these builtins. This puts
us down the variadic type check rules for scalar inputs to these builtins
@@ -2393,8 +2395,10 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned
BuiltinID, CallExpr *TheCall) {
if (CheckVectorElementCallArgs(&SemaRef, TheCall))
return true;
if (SemaRef.BuiltinElementwiseTernaryMath(
-TheCall, /*CheckForFloatArgs*/
-
llvmbot wrote:
@llvm/pr-subscribers-hlsl
Author: Fraser Cormack (frasercrmck)
Changes
This commit improves the diagnostics for vector (elementwise) builtins in a
couple of ways.
It primarily provides more precise type-checking diagnostics for builtins with
specific type requirements. Pr
llvmbot wrote:
@llvm/pr-subscribers-backend-risc-v
Author: Fraser Cormack (frasercrmck)
Changes
This commit improves the diagnostics for vector (elementwise) builtins in a
couple of ways.
It primarily provides more precise type-checking diagnostics for builtins with
specific type requir
https://github.com/frasercrmck created
https://github.com/llvm/llvm-project/pull/125673
This commit improves the diagnostics for vector (elementwise) builtins in a
couple of ways.
It primarily provides more precise type-checking diagnostics for builtins with
specific type requirements. Previo
21 matches
Mail list logo
