llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`openmp-offload-amdgpu-runtime` running on `omp-vega20-0` while building
`clang` at step 7 "Add check check-offload".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/30/builds/15573
Here is the releva
github-actions[bot] wrote:
@YutongZhuu Congratulations on having your first Pull Request (PR) merged into
the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a bui
https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/125370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM, thank you for the fix!
https://github.com/llvm/llvm-project/pull/125370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
@@ -121,6 +121,186 @@ Attribute Changes in Clang
Improvements to Clang's diagnostics
---
+- Some template related diagnostics have been improved.
+
+ .. code-block:: c++
+
+ void foo() { template int i; } // error: templates can only be
d
@@ -121,6 +121,186 @@ Attribute Changes in Clang
Improvements to Clang's diagnostics
---
+- Some template related diagnostics have been improved.
+
+ .. code-block:: c++
+
+ void foo() { template int i; } // error: templates can only be
d
@@ -121,6 +121,186 @@ Attribute Changes in Clang
Improvements to Clang's diagnostics
---
+- Some template related diagnostics have been improved.
+
+ .. code-block:: c++
+
+ void foo() { template int i; } // error: templates can only be
d
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/125370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -121,6 +121,186 @@ Attribute Changes in Clang
Improvements to Clang's diagnostics
---
+- Some template related diagnostics have been improved.
+
+ .. code-block:: c++
+
+ void foo() { template int i; } // error: templates can only be
d
@@ -121,6 +121,186 @@ Attribute Changes in Clang
Improvements to Clang's diagnostics
---
+- Some template related diagnostics have been improved.
+
+ .. code-block:: c++
+
+ void foo() { template int i; } // error: templates can only be
d
https://github.com/AaronBallman commented:
Aside from the issue with the release notes, I think this LGTM!
https://github.com/llvm/llvm-project/pull/125370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
https://github.com/YutongZhuu updated
https://github.com/llvm/llvm-project/pull/125370
>From 380ae2020f71cc5006db2e29b0a69f61297f585c Mon Sep 17 00:00:00 2001
From: Yutong Zhu
Date: Sat, 1 Feb 2025 20:09:13 -0500
Subject: [PATCH 1/3] Force AttributedStmtClass to not be scope parents
---
clang
https://github.com/YutongZhuu updated
https://github.com/llvm/llvm-project/pull/125370
>From 380ae2020f71cc5006db2e29b0a69f61297f585c Mon Sep 17 00:00:00 2001
From: Yutong Zhu
Date: Sat, 1 Feb 2025 20:09:13 -0500
Subject: [PATCH 1/2] Force AttributedStmtClass to not be scope parents
---
clang
YutongZhuu wrote:
> Could you add a test case - check in clang/test to see if other tests for the
> diagnostic text in the original bug, and add a test case for that nearby
> (maybe the same file the diagnostic is already tested in)?
Done
https://github.com/llvm/llvm-project/pull/125370
_
https://github.com/YutongZhuu updated
https://github.com/llvm/llvm-project/pull/125370
>From 380ae2020f71cc5006db2e29b0a69f61297f585c Mon Sep 17 00:00:00 2001
From: Yutong Zhu
Date: Sat, 1 Feb 2025 20:09:13 -0500
Subject: [PATCH 1/2] Force AttributedStmtClass to not be scope parents
---
clang
https://github.com/YutongZhuu updated
https://github.com/llvm/llvm-project/pull/125370
>From 380ae2020f71cc5006db2e29b0a69f61297f585c Mon Sep 17 00:00:00 2001
From: Yutong Zhu
Date: Sat, 1 Feb 2025 20:09:13 -0500
Subject: [PATCH] Force AttributedStmtClass to not be scope parents
---
clang/doc
https://github.com/YutongZhuu edited
https://github.com/llvm/llvm-project/pull/125370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/YutongZhuu edited
https://github.com/llvm/llvm-project/pull/125370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/YutongZhuu edited
https://github.com/llvm/llvm-project/pull/125370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
YutongZhuu wrote:
> Could you add a test case - check in clang/test to see if other tests for the
> diagnostic text in the original bug, and add a test case for that nearby
> (maybe the same file the diagnostic is already tested in)?
Do you mean I should check if there exists a test for the or
https://github.com/YutongZhuu edited
https://github.com/llvm/llvm-project/pull/125370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -658,7 +649,13 @@ void JumpScopeChecker::BuildScopeInformation(Stmt *S,
Next = SC->getSubStmt();
else if (LabelStmt *LS = dyn_cast(SubStmt))
Next = LS->getSubStmt();
- else
+ else if (AttributedStmt *AS = dyn_cast(SubStmt)) {
+if (GetM
https://github.com/YutongZhuu edited
https://github.com/llvm/llvm-project/pull/125370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
Thank you for the fix!
> Could you add a test case - check in clang/test to see if other tests for the
> diagnostic text in the original bug, and add a test case for that nearby
> (maybe the same file the diagnostic is already tested in)?
Also, please add a more descriptiv
dwblaikie wrote:
Could you add a test case - check in clang/test to see if other tests for the
diagnostic text in the original bug, and add a test case for that nearby (maybe
the same file the diagnostic is already tested in)?
https://github.com/llvm/llvm-project/pull/125370
__
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Yutong Zhu (YutongZhuu)
Changes
This PR addresses https://github.com/llvm/llvm-project/issues/84072.
---
Full diff: https://github.com/llvm/llvm-project/pull/125370.diff
1 Files Affected:
- (modified) clang/lib/Sema/JumpDiagnostics.cpp
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/YutongZhuu created
https://github.com/llvm/llvm-project/pull/125370
This PR addresses https://github.com/llvm/llvm-project/issues/84072.
>From 01497e746ae23ea5033b1c6cd6f9f9718d6dc3d6 Mon Sep 17 00:00:00 2001
From: Yutong Zhu
Date: Sat, 1 Feb 2025 20:09:13 -0500
Subject: [PA
28 matches
Mail list logo
