AaronBallman wrote:

Thank you for the fix!

> Could you add a test case - check in clang/test to see if other tests for the 
> diagnostic text in the original bug, and add a test case for that nearby 
> (maybe the same file the diagnostic is already tested in)?

Also, please add a more descriptive summary of what's changing and why (it 
makes it easier on us when we have to dig through a blame a few years down the 
line) and a release note in `clang/docs/ReleaseNotes.rst` so users know about 
the fix.

https://github.com/llvm/llvm-project/pull/125370
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to