[clang] [clang] Add missing canonicalization in int literal profile (PR #67822)

2023-10-02 Thread Henrik G. Olsson via cfe-commits
https://github.com/hnrklssn closed https://github.com/llvm/llvm-project/pull/67822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add missing canonicalization in int literal profile (PR #67822)

2023-09-29 Thread via cfe-commits
https://github.com/DonatNagyE edited https://github.com/llvm/llvm-project/pull/67822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add missing canonicalization in int literal profile (PR #67822)

2023-09-29 Thread via cfe-commits
https://github.com/DonatNagyE edited https://github.com/llvm/llvm-project/pull/67822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add missing canonicalization in int literal profile (PR #67822)

2023-09-29 Thread via cfe-commits
https://github.com/DonatNagyE approved this pull request. LGTM. By the way, as I searched for other applications of the flag `Canonical`, I noticed that `StmtProfiler` has a `VisitType(QualType T)` method which "cheats" and just stores `T` as an opaque pointer. If the pointer value is canonica

[clang] [clang] Add missing canonicalization in int literal profile (PR #67822)

2023-09-29 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/67822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add missing canonicalization in int literal profile (PR #67822)

2023-09-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes The addition of the type kind to the profile ID of IntegerLiterals results in e.g. size_t and unsigned long literals mismatch even on platforms where they are canonically the same type. This patch checks the Canonical field to determine w

[clang] [clang] Add missing canonicalization in int literal profile (PR #67822)

2023-09-29 Thread Henrik G. Olsson via cfe-commits
https://github.com/hnrklssn created https://github.com/llvm/llvm-project/pull/67822 The addition of the type kind to the profile ID of IntegerLiterals results in e.g. size_t and unsigned long literals mismatch even on platforms where they are canonically the same type. This patch checks the Ca