https://github.com/DonatNagyE approved this pull request.
LGTM. By the way, as I searched for other applications of the flag `Canonical`, I noticed that `StmtProfiler` has a `VisitType(QualType T)` method which "cheats" and just stores `T` as an opaque pointer. If the pointer value is canonical enough (which I presume), then calling that could provide a different way for implementing `VisitIntegerLiteral` -- but the current code is also OK after your correction. https://github.com/llvm/llvm-project/pull/67822 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
