@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
Sirraide wrote:
@zyn0217 You missed my last comment on the discussion above there
https://github.com/llvm/llvm-project/pull/86914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/86914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
zyn0217 wrote:
(Since there haven't been any changes besides comments after the very first
commit, which has passed the CI, so I'm landing it anyway.)
https://github.com/llvm/llvm-project/pull/86914
___
cfe-commits mailing list
cfe-commits@lists.llvm.
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/86914
>From b31ca786d937dc180ad02042132596b2e5f3710f Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Thu, 28 Mar 2024 14:13:12 +0800
Subject: [PATCH 1/4] [clang][Sema] Fix a CTAD regression after 42239d2e9
The most
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/86914
>From b31ca786d937dc180ad02042132596b2e5f3710f Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Thu, 28 Mar 2024 14:13:12 +0800
Subject: [PATCH 1/3] [clang][Sema] Fix a CTAD regression after 42239d2e9
The most
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/86914
>From b31ca786d937dc180ad02042132596b2e5f3710f Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Thu, 28 Mar 2024 14:13:12 +0800
Subject: [PATCH 1/2] [clang][Sema] Fix a CTAD regression after 42239d2e9
The most
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/86914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
https://github.com/Sirraide deleted
https://github.com/llvm/llvm-project/pull/86914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide deleted
https://github.com/llvm/llvm-project/pull/86914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
https://github.com/hokein approved this pull request.
thanks, this looks good from my side.
https://github.com/llvm/llvm-project/pull/86914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/86914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Younan Zhang (zyn0217)
Changes
The most recent declaration of a template as a friend can introduce a different
template parameter depth compared to what we anticipate from a CTAD guide.
Fixes https://github.com/llvm/llvm-project/issues/86
https://github.com/zyn0217 ready_for_review
https://github.com/llvm/llvm-project/pull/86914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/86914
The most recent declaration of a template as a friend can introduce a different
template parameter depth compared to what we anticipate from a CTAD guide.
Fixes https://github.com/llvm/llvm-project/issues/86769
29 matches
Mail list logo
