@@ -80,14 +86,21 @@ namespace dr5 { // dr5: 3.1
namespace dr7 { // dr7: 3.4
class A { public: ~A(); };
- class B : virtual private A {}; // expected-note 2 {{declared private here}}
- class C : public B {} c; // expected-error 2 {{inherited virtual base class
'A' has priv
erichkeane wrote:
> > I could nit on the naming conventions here or there, but I think this
> > overall is such a vast improvement that I'd rather get 'this', then argue
> > on names in future files, and let this one lie.
>
> @erichkeane Now is the best time to bring those nits on, unless you
Endilll wrote:
> I could nit on the naming conventions here or there, but I think this overall
> is such a vast improvement that I'd rather get 'this', then argue on names in
> future files, and let this one lie.
@erichkeane Now is the best time to bring those nits on, unless you want
changes
@@ -80,14 +86,21 @@ namespace dr5 { // dr5: 3.1
namespace dr7 { // dr7: 3.4
class A { public: ~A(); };
- class B : virtual private A {}; // expected-note 2 {{declared private here}}
- class C : public B {} c; // expected-error 2 {{inherited virtual base class
'A' has priv
@@ -80,14 +86,21 @@ namespace dr5 { // dr5: 3.1
namespace dr7 { // dr7: 3.4
class A { public: ~A(); };
- class B : virtual private A {}; // expected-note 2 {{declared private here}}
- class C : public B {} c; // expected-error 2 {{inherited virtual base class
'A' has priv
@@ -80,14 +86,21 @@ namespace dr5 { // dr5: 3.1
namespace dr7 { // dr7: 3.4
class A { public: ~A(); };
- class B : virtual private A {}; // expected-note 2 {{declared private here}}
- class C : public B {} c; // expected-error 2 {{inherited virtual base class
'A' has priv
https://github.com/shafik commented:
I think I mostly like this direction.
https://github.com/llvm/llvm-project/pull/73879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/73879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Endilll wrote:
I'm putting this NFC for a review, because that's the direction I'd like our DR
test suite to take. If it goes well, I'll go on and refactor the rest of the
test suite in this manner.
https://github.com/llvm/llvm-project/pull/73879
___
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Vlad Serebrennikov (Endilll)
Changes
This patch converts (almost) every expected directive in
`test/CXX/drs/dr0xx.cpp` into either `@-1` form (when directive immediately
follow the line diagnostic is pointing out to), or `@#` form
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/73879
This patch converts (almost) every expected directive in
`test/CXX/drs/dr0xx.cpp` into either `@-1` form (when directive immediately
follow the line diagnostic is pointing out to), or `@#` form (when
directive
11 matches
Mail list logo
