[clang] [StrTable] Mechanically convert NVPTX builtins to use TableGen (PR #122873)

@@ -0,0 +1,1078 @@ +//===--- BuiltinsNVPTX.td - NVPTX Builtin function defs -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: A

[clang] [StrTable] Mechanically convert NVPTX builtins to use TableGen (PR #122873)

@@ -104,9 +104,39 @@ class PrototypeParser { void ParseType(StringRef T) { T = T.trim(); + +auto ConsumeAddrSpace = [&]() -> std::optional { + T = T.trim(); + if (!T.consume_back(">")) +return std::nullopt; + + auto Open = T.find_last_of('<');

[clang] [StrTable] Mechanically convert NVPTX builtins to use TableGen (PR #122873)

@@ -104,9 +104,39 @@ class PrototypeParser { void ParseType(StringRef T) { T = T.trim(); + +auto ConsumeAddrSpace = [&]() -> std::optional { + T = T.trim(); + if (!T.consume_back(">")) +return std::nullopt; + + auto Open = T.find_last_of('<');

[clang] [StrTable] Mechanically convert NVPTX builtins to use TableGen (PR #122873)

https://github.com/Artem-B approved this pull request. LGTM overall with a couple of nits. I like the direction of the change. Tablegen is probably a better way to handle NVPTX quirks, than a preprocessor. We may finally be able to replace the string-based constraints that are growing a bit to

[clang] [StrTable] Mechanically convert NVPTX builtins to use TableGen (PR #122873)

https://github.com/Artem-B edited https://github.com/llvm/llvm-project/pull/122873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [StrTable] Mechanically convert NVPTX builtins to use TableGen (PR #122873)

@@ -0,0 +1,1078 @@ +//===--- BuiltinsNVPTX.td - NVPTX Builtin function defs -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: A

[clang] [StrTable] Mechanically convert NVPTX builtins to use TableGen (PR #122873)

https://github.com/durga4github edited https://github.com/llvm/llvm-project/pull/122873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [StrTable] Mechanically convert NVPTX builtins to use TableGen (PR #122873)

durga4github wrote: LGTM overall. I work with these builtins only occasionally. So, let us wait for Artem's review. https://github.com/llvm/llvm-project/pull/122873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [StrTable] Mechanically convert NVPTX builtins to use TableGen (PR #122873)

@@ -0,0 +1,1078 @@ +//===--- BuiltinsNVPTX.td - NVPTX Builtin function defs -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: A

[clang] [StrTable] Mechanically convert NVPTX builtins to use TableGen (PR #122873)

durga4github wrote: > Ping! > > I've updated this to incorporate the changes in #123398 to the NVPTX.def file > this is replacing. > Thanks for this! https://github.com/llvm/llvm-project/pull/122873 ___ cfe-commits mailing list cfe-commits@lists

[clang] [StrTable] Mechanically convert NVPTX builtins to use TableGen (PR #122873)

chandlerc wrote: Ping! I've updated this to incorporate the changes in #123398 to the NVPTX.def file this is replacing. Adding the author & reviewers of that PR to this -- I'd really like to either get this landed or figure out what other approach to use it avoid having to continually update

[clang] [StrTable] Mechanically convert NVPTX builtins to use TableGen (PR #122873)

chandlerc wrote: Ping -- a week now with no review. https://github.com/llvm/llvm-project/pull/122873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [StrTable] Mechanically convert NVPTX builtins to use TableGen (PR #122873)

https://github.com/chandlerc edited https://github.com/llvm/llvm-project/pull/122873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits