https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/138266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman updated
https://github.com/llvm/llvm-project/pull/138266
>From 2af347fd15a839b5df3f15ab18d1034aa180481b Mon Sep 17 00:00:00 2001
From: Aaron Ballman
Date: Fri, 2 May 2025 08:54:53 -0400
Subject: [PATCH 1/2] [C] Update the -Wdefault-const-init-unsafe wording
This
erichkeane wrote:
> > I'm not sure I buy the justification
>
> FWIW, this came from a post-commit review comment: [#137166
> (comment)](https://github.com/llvm/llvm-project/pull/137166#discussion_r2070615023)
>
> > , and the flag-diag there is perhaps 'cute' (and frankly, if we find
> > ourse
AaronBallman wrote:
> I'm not sure I buy the justification
FWIW, this came from a post-commit review comment:
https://github.com/llvm/llvm-project/pull/137166#discussion_r2070615023
>, and the flag-diag there is perhaps 'cute' (and frankly, if we find ourself
>doing that again, I would vastly
https://github.com/erichkeane approved this pull request.
I'm not sure I buy the justification, and the flag-diag there is perhaps 'cute'
(and frankly, if we find ourself doing that again, I would vastly prefer we do
something like this in tablegen/Diagnostics directly to auto generate/check
t
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Aaron Ballman (AaronBallman)
Changes
This drops the "and is incompatible with C++" phrasing from the diagnostic
unless -Wc++-compat is explicitly passed. This makes the diagnostic less
confusing when it is on by default rather than enable
https://github.com/AaronBallman created
https://github.com/llvm/llvm-project/pull/138266
This drops the "and is incompatible with C++" phrasing from the diagnostic
unless -Wc++-compat is explicitly passed. This makes the diagnostic less
confusing when it is on by default rather than enabled be
