AaronBallman wrote: > I'm not sure I buy the justification
FWIW, this came from a post-commit review comment: https://github.com/llvm/llvm-project/pull/137166#discussion_r2070615023 >, and the flag-diag there is perhaps 'cute' (and frankly, if we find ourself >doing that again, I would vastly prefer we do something like this in >tablegen/Diagnostics directly to auto generate/check these things in a way >that cannot be called. Yeah, at some point we may want to update the diagnostics engine so it can track groups directly instead of by warning, or at the very least, hide this kind of hack behind an interface on `DiagnosticsEngine`. https://github.com/llvm/llvm-project/pull/138266 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
